-
Notifications
You must be signed in to change notification settings - Fork 319
Adjust create-release-branch workflow
#9833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: beb0548 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~beb0548829, baseline=1.55.0-SNAPSHOT~17ad12a278
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1016646
Total [baseline] (10.661 s) : 0, 10661229
Agent [candidate] (1.032 s) : 0, 1031620
Total [candidate] (10.741 s) : 0, 10741233
section appsec
Agent [baseline] (1.196 s) : 0, 1196002
Total [baseline] (10.816 s) : 0, 10816136
Agent [candidate] (1.195 s) : 0, 1195086
Total [candidate] (10.836 s) : 0, 10836388
section iast
Agent [baseline] (1.152 s) : 0, 1151670
Total [baseline] (11.072 s) : 0, 11072219
Agent [candidate] (1.15 s) : 0, 1150488
Total [candidate] (11.035 s) : 0, 11035464
section profiling
Agent [baseline] (1.163 s) : 0, 1163285
Total [baseline] (10.847 s) : 0, 10847307
Agent [candidate] (1.171 s) : 0, 1171238
Total [candidate] (10.839 s) : 0, 10838677
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~beb0548829, baseline=1.55.0-SNAPSHOT~17ad12a278
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (693.351 ms) : 0, 693351
BytebuddyAgent [candidate] (702.991 ms) : 0, 702991
GlobalTracer [baseline] (242.609 ms) : 0, 242609
GlobalTracer [candidate] (245.446 ms) : 0, 245446
AppSec [baseline] (32.17 ms) : 0, 32170
AppSec [candidate] (32.786 ms) : 0, 32786
Debugger [baseline] (6.247 ms) : 0, 6247
Debugger [candidate] (6.418 ms) : 0, 6418
Remote Config [baseline] (667.753 µs) : 0, 668
Remote Config [candidate] (692.468 µs) : 0, 692
Telemetry [baseline] (9.263 ms) : 0, 9263
Telemetry [candidate] (9.342 ms) : 0, 9342
Flare Poller [baseline] (9.659 ms) : 0, 9659
Flare Poller [candidate] (11.168 ms) : 0, 11168
section appsec
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (718.765 ms) : 0, 718765
BytebuddyAgent [candidate] (718.056 ms) : 0, 718056
GlobalTracer [baseline] (235.135 ms) : 0, 235135
GlobalTracer [candidate] (235.384 ms) : 0, 235384
AppSec [baseline] (175.386 ms) : 0, 175386
AppSec [candidate] (174.902 ms) : 0, 174902
Debugger [baseline] (6.075 ms) : 0, 6075
Debugger [candidate] (6.103 ms) : 0, 6103
Remote Config [baseline] (644.231 µs) : 0, 644
Remote Config [candidate] (631.195 µs) : 0, 631
Telemetry [baseline] (8.581 ms) : 0, 8581
Telemetry [candidate] (8.526 ms) : 0, 8526
Flare Poller [baseline] (3.855 ms) : 0, 3855
Flare Poller [candidate] (3.816 ms) : 0, 3816
IAST [baseline] (24.881 ms) : 0, 24881
IAST [candidate] (24.994 ms) : 0, 24994
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (815.362 ms) : 0, 815362
BytebuddyAgent [candidate] (814.485 ms) : 0, 814485
GlobalTracer [baseline] (231.597 ms) : 0, 231597
GlobalTracer [candidate] (231.2 ms) : 0, 231200
AppSec [baseline] (35.21 ms) : 0, 35210
AppSec [candidate] (35.217 ms) : 0, 35217
Debugger [baseline] (6.188 ms) : 0, 6188
Debugger [candidate] (6.175 ms) : 0, 6175
Remote Config [baseline] (605.59 µs) : 0, 606
Remote Config [candidate] (605.992 µs) : 0, 606
Telemetry [baseline] (8.743 ms) : 0, 8743
Telemetry [candidate] (8.754 ms) : 0, 8754
Flare Poller [baseline] (4.304 ms) : 0, 4304
Flare Poller [candidate] (4.32 ms) : 0, 4320
IAST [baseline] (26.654 ms) : 0, 26654
IAST [candidate] (26.778 ms) : 0, 26778
section profiling
ProfilingAgent [baseline] (109.848 ms) : 0, 109848
ProfilingAgent [candidate] (110.596 ms) : 0, 110596
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (720.02 ms) : 0, 720020
BytebuddyAgent [candidate] (725.049 ms) : 0, 725049
GlobalTracer [baseline] (218.485 ms) : 0, 218485
GlobalTracer [candidate] (219.731 ms) : 0, 219731
AppSec [baseline] (32.202 ms) : 0, 32202
AppSec [candidate] (32.582 ms) : 0, 32582
Debugger [baseline] (6.618 ms) : 0, 6618
Debugger [candidate] (7.59 ms) : 0, 7590
Remote Config [baseline] (685.834 µs) : 0, 686
Remote Config [candidate] (688.508 µs) : 0, 689
Telemetry [baseline] (14.972 ms) : 0, 14972
Telemetry [candidate] (15.175 ms) : 0, 15175
Flare Poller [baseline] (5.066 ms) : 0, 5066
Flare Poller [candidate] (4.172 ms) : 0, 4172
Profiling [baseline] (110.493 ms) : 0, 110493
Profiling [candidate] (111.224 ms) : 0, 111224
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~beb0548829, baseline=1.55.0-SNAPSHOT~17ad12a278
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1021780
Total [baseline] (8.701 s) : 0, 8701295
Agent [candidate] (1.021 s) : 0, 1021412
Total [candidate] (8.652 s) : 0, 8651565
section iast
Agent [baseline] (1.161 s) : 0, 1161400
Total [baseline] (9.37 s) : 0, 9370187
Agent [candidate] (1.15 s) : 0, 1149833
Total [candidate] (9.273 s) : 0, 9273019
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~beb0548829, baseline=1.55.0-SNAPSHOT~17ad12a278
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (695.694 ms) : 0, 695694
BytebuddyAgent [candidate] (695.102 ms) : 0, 695102
GlobalTracer [baseline] (243.664 ms) : 0, 243664
GlobalTracer [candidate] (243.302 ms) : 0, 243302
AppSec [baseline] (32.444 ms) : 0, 32444
AppSec [candidate] (32.295 ms) : 0, 32295
Debugger [baseline] (6.327 ms) : 0, 6327
Debugger [candidate] (6.29 ms) : 0, 6290
Remote Config [baseline] (687.233 µs) : 0, 687
Remote Config [candidate] (673.045 µs) : 0, 673
Telemetry [baseline] (9.243 ms) : 0, 9243
Telemetry [candidate] (9.487 ms) : 0, 9487
Flare Poller [baseline] (11.058 ms) : 0, 11058
Flare Poller [candidate] (11.719 ms) : 0, 11719
section iast
crashtracking [baseline] (1.498 ms) : 0, 1498
crashtracking [candidate] (1.491 ms) : 0, 1491
BytebuddyAgent [baseline] (822.422 ms) : 0, 822422
BytebuddyAgent [candidate] (813.722 ms) : 0, 813722
GlobalTracer [baseline] (233.325 ms) : 0, 233325
GlobalTracer [candidate] (231.61 ms) : 0, 231610
AppSec [baseline] (35.623 ms) : 0, 35623
AppSec [candidate] (35.191 ms) : 0, 35191
Debugger [baseline] (6.146 ms) : 0, 6146
Debugger [candidate] (6.14 ms) : 0, 6140
Remote Config [baseline] (599.167 µs) : 0, 599
Remote Config [candidate] (602.838 µs) : 0, 603
Telemetry [baseline] (8.653 ms) : 0, 8653
Telemetry [candidate] (8.725 ms) : 0, 8725
Flare Poller [baseline] (4.191 ms) : 0, 4191
Flare Poller [candidate] (4.283 ms) : 0, 4283
IAST [baseline] (27.33 ms) : 0, 27330
IAST [candidate] (26.702 ms) : 0, 26702
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~beb0548829, baseline=1.55.0-SNAPSHOT~17ad12a278
dateFormat X
axisFormat %s
section baseline
no_agent (38.301 ms) : 37996, 38606
. : milestone, 38301,
appsec (47.386 ms) : 46978, 47794
. : milestone, 47386,
code_origins (43.459 ms) : 43096, 43822
. : milestone, 43459,
iast (44.286 ms) : 43894, 44678
. : milestone, 44286,
profiling (49.901 ms) : 49464, 50337
. : milestone, 49901,
tracing (43.885 ms) : 43508, 44262
. : milestone, 43885,
section candidate
no_agent (38.162 ms) : 37851, 38473
. : milestone, 38162,
appsec (47.955 ms) : 47526, 48384
. : milestone, 47955,
code_origins (44.022 ms) : 43650, 44394
. : milestone, 44022,
iast (44.822 ms) : 44427, 45217
. : milestone, 44822,
profiling (50.745 ms) : 50215, 51276
. : milestone, 50745,
tracing (42.856 ms) : 42496, 43215
. : milestone, 42856,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~beb0548829, baseline=1.55.0-SNAPSHOT~17ad12a278
dateFormat X
axisFormat %s
section baseline
no_agent (4.323 ms) : 4276, 4370
. : milestone, 4323,
iast (9.593 ms) : 9423, 9763
. : milestone, 9593,
iast_FULL (14.314 ms) : 14025, 14603
. : milestone, 14314,
iast_GLOBAL (10.43 ms) : 10243, 10617
. : milestone, 10430,
profiling (9.059 ms) : 8919, 9199
. : milestone, 9059,
tracing (8.605 ms) : 8479, 8730
. : milestone, 8605,
section candidate
no_agent (4.337 ms) : 4280, 4394
. : milestone, 4337,
iast (10.048 ms) : 9873, 10223
. : milestone, 10048,
iast_FULL (14.194 ms) : 13913, 14476
. : milestone, 14194,
iast_GLOBAL (10.691 ms) : 10500, 10882
. : milestone, 10691,
profiling (8.927 ms) : 8787, 9068
. : milestone, 8927,
tracing (8.211 ms) : 8081, 8341
. : milestone, 8211,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~beb0548829, baseline=1.55.0-SNAPSHOT~17ad12a278
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (3.696 ms) : 3478, 3915
. : milestone, 3696,
iast (2.212 ms) : 2148, 2276
. : milestone, 2212,
iast_GLOBAL (2.26 ms) : 2196, 2325
. : milestone, 2260,
profiling (2.055 ms) : 2003, 2107
. : milestone, 2055,
tracing (2.034 ms) : 1984, 2085
. : milestone, 2034,
section candidate
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.615 ms) : 3401, 3829
. : milestone, 3615,
iast (2.206 ms) : 2141, 2270
. : milestone, 2206,
iast_GLOBAL (2.246 ms) : 2181, 2310
. : milestone, 2246,
profiling (2.049 ms) : 1997, 2102
. : milestone, 2049,
tracing (2.016 ms) : 1966, 2066
. : milestone, 2016,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~beb0548829, baseline=1.55.0-SNAPSHOT~17ad12a278
dateFormat X
axisFormat %s
section baseline
no_agent (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
appsec (14.633 s) : 14633000, 14633000
. : milestone, 14633000,
iast (18.747 s) : 18747000, 18747000
. : milestone, 18747000,
iast_GLOBAL (17.963 s) : 17963000, 17963000
. : milestone, 17963000,
profiling (15.373 s) : 15373000, 15373000
. : milestone, 15373000,
tracing (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
section candidate
no_agent (15.511 s) : 15511000, 15511000
. : milestone, 15511000,
appsec (14.939 s) : 14939000, 14939000
. : milestone, 14939000,
iast (18.636 s) : 18636000, 18636000
. : milestone, 18636000,
iast_GLOBAL (17.662 s) : 17662000, 17662000
. : milestone, 17662000,
profiling (15.133 s) : 15133000, 15133000
. : milestone, 15133000,
tracing (15.302 s) : 15302000, 15302000
. : milestone, 15302000,
|
What Does This Do
Adjust the
create-release-branchworkflow such that instead of:it now:
Motivation
The release branch is protected and requires changes, such as pinning system tests, to be made through a separate branch that is then approved and merged into the release branch, instead of committed directly to the branch.
Additional Notes
Sigh, I confirmed again that I can only test on
master: https://github.com/DataDog/dd-trace-java/actions/runs/18723984882/job/53403708326Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]