-
Notifications
You must be signed in to change notification settings - Fork 319
Cleaning Up Unused and Ambiguous Configurations #10094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
424147d to
1751acd
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
supported-configurations.json
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~3c3a0c57aa, baseline=1.57.0-SNAPSHOT~823cec6aa6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1080645
Total [baseline] (8.744 s) : 0, 8744123
Agent [candidate] (1.082 s) : 0, 1082456
Total [candidate] (8.752 s) : 0, 8752459
section iast
Agent [baseline] (1.222 s) : 0, 1221554
Total [baseline] (9.463 s) : 0, 9463169
Agent [candidate] (1.225 s) : 0, 1224512
Total [candidate] (9.469 s) : 0, 9468886
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~3c3a0c57aa, baseline=1.57.0-SNAPSHOT~823cec6aa6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (648.972 ms) : 0, 648972
BytebuddyAgent [candidate] (650.047 ms) : 0, 650047
GlobalTracer [baseline] (282.142 ms) : 0, 282142
GlobalTracer [candidate] (282.481 ms) : 0, 282481
AppSec [baseline] (32.218 ms) : 0, 32218
AppSec [candidate] (32.314 ms) : 0, 32314
Debugger [baseline] (67.128 ms) : 0, 67128
Debugger [candidate] (67.404 ms) : 0, 67404
Remote Config [baseline] (659.821 µs) : 0, 660
Remote Config [candidate] (659.106 µs) : 0, 659
Telemetry [baseline] (9.043 ms) : 0, 9043
Telemetry [candidate] (9.072 ms) : 0, 9072
Flare Poller [baseline] (3.684 ms) : 0, 3684
Flare Poller [candidate] (3.766 ms) : 0, 3766
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (789.699 ms) : 0, 789699
BytebuddyAgent [candidate] (792.009 ms) : 0, 792009
GlobalTracer [baseline] (255.416 ms) : 0, 255416
GlobalTracer [candidate] (256.292 ms) : 0, 256292
AppSec [baseline] (35.316 ms) : 0, 35316
AppSec [candidate] (35.327 ms) : 0, 35327
Debugger [baseline] (65.136 ms) : 0, 65136
Debugger [candidate] (64.839 ms) : 0, 64839
Remote Config [baseline] (541.384 µs) : 0, 541
Remote Config [candidate] (538.062 µs) : 0, 538
Telemetry [baseline] (8.429 ms) : 0, 8429
Telemetry [candidate] (8.411 ms) : 0, 8411
Flare Poller [baseline] (3.445 ms) : 0, 3445
Flare Poller [candidate] (3.471 ms) : 0, 3471
IAST [baseline] (26.968 ms) : 0, 26968
IAST [candidate] (27.008 ms) : 0, 27008
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~3c3a0c57aa, baseline=1.57.0-SNAPSHOT~823cec6aa6
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079535
Total [baseline] (10.785 s) : 0, 10785326
Agent [candidate] (1.081 s) : 0, 1081085
Total [candidate] (10.8 s) : 0, 10800266
section appsec
Agent [baseline] (1.283 s) : 0, 1282726
Total [baseline] (11.252 s) : 0, 11252209
Agent [candidate] (1.273 s) : 0, 1272593
Total [candidate] (11.215 s) : 0, 11214585
section iast
Agent [baseline] (1.235 s) : 0, 1234774
Total [baseline] (11.216 s) : 0, 11215605
Agent [candidate] (1.227 s) : 0, 1226824
Total [candidate] (11.199 s) : 0, 11199143
section profiling
Agent [baseline] (1.213 s) : 0, 1213458
Total [baseline] (11.036 s) : 0, 11036120
Agent [candidate] (1.205 s) : 0, 1205474
Total [candidate] (10.989 s) : 0, 10988995
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~3c3a0c57aa, baseline=1.57.0-SNAPSHOT~823cec6aa6
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (647.431 ms) : 0, 647431
BytebuddyAgent [candidate] (648.342 ms) : 0, 648342
GlobalTracer [baseline] (281.617 ms) : 0, 281617
GlobalTracer [candidate] (282.154 ms) : 0, 282154
AppSec [baseline] (32.545 ms) : 0, 32545
AppSec [candidate] (32.454 ms) : 0, 32454
Debugger [baseline] (67.904 ms) : 0, 67904
Debugger [candidate] (68.086 ms) : 0, 68086
Remote Config [baseline] (640.44 µs) : 0, 640
Remote Config [candidate] (664.882 µs) : 0, 665
Telemetry [baseline] (9.014 ms) : 0, 9014
Telemetry [candidate] (9.049 ms) : 0, 9049
Flare Poller [baseline] (3.734 ms) : 0, 3734
Flare Poller [candidate] (3.707 ms) : 0, 3707
section appsec
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (700.164 ms) : 0, 700164
BytebuddyAgent [candidate] (694.426 ms) : 0, 694426
GlobalTracer [baseline] (262.855 ms) : 0, 262855
GlobalTracer [candidate] (260.926 ms) : 0, 260926
AppSec [baseline] (176.193 ms) : 0, 176193
AppSec [candidate] (175.585 ms) : 0, 175585
Debugger [baseline] (67.821 ms) : 0, 67821
Debugger [candidate] (66.469 ms) : 0, 66469
Remote Config [baseline] (716.936 µs) : 0, 717
Remote Config [candidate] (695.049 µs) : 0, 695
Telemetry [baseline] (9.029 ms) : 0, 9029
Telemetry [candidate] (8.877 ms) : 0, 8877
Flare Poller [baseline] (3.973 ms) : 0, 3973
Flare Poller [candidate] (3.851 ms) : 0, 3851
IAST [baseline] (24.964 ms) : 0, 24964
IAST [candidate] (24.806 ms) : 0, 24806
section iast
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (799.002 ms) : 0, 799002
BytebuddyAgent [candidate] (792.769 ms) : 0, 792769
GlobalTracer [baseline] (257.957 ms) : 0, 257957
GlobalTracer [candidate] (256.615 ms) : 0, 256615
AppSec [baseline] (35.499 ms) : 0, 35499
AppSec [candidate] (35.296 ms) : 0, 35296
Debugger [baseline] (65.648 ms) : 0, 65648
Debugger [candidate] (65.882 ms) : 0, 65882
Remote Config [baseline] (532.117 µs) : 0, 532
Remote Config [candidate] (550.227 µs) : 0, 550
Telemetry [baseline] (8.445 ms) : 0, 8445
Telemetry [candidate] (8.487 ms) : 0, 8487
Flare Poller [baseline] (3.441 ms) : 0, 3441
Flare Poller [candidate] (3.421 ms) : 0, 3421
IAST [baseline] (27.361 ms) : 0, 27361
IAST [candidate] (27.154 ms) : 0, 27154
section profiling
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (707.069 ms) : 0, 707069
BytebuddyAgent [candidate] (701.927 ms) : 0, 701927
GlobalTracer [baseline] (223.082 ms) : 0, 223082
GlobalTracer [candidate] (221.302 ms) : 0, 221302
AppSec [baseline] (32.66 ms) : 0, 32660
AppSec [candidate] (32.265 ms) : 0, 32265
Debugger [baseline] (68.57 ms) : 0, 68570
Debugger [candidate] (68.138 ms) : 0, 68138
Remote Config [baseline] (657.369 µs) : 0, 657
Remote Config [candidate] (631.261 µs) : 0, 631
Telemetry [baseline] (8.985 ms) : 0, 8985
Telemetry [candidate] (8.977 ms) : 0, 8977
Flare Poller [baseline] (3.787 ms) : 0, 3787
Flare Poller [candidate] (3.794 ms) : 0, 3794
ProfilingAgent [baseline] (97.356 ms) : 0, 97356
ProfilingAgent [candidate] (97.51 ms) : 0, 97510
Profiling [baseline] (97.926 ms) : 0, 97926
Profiling [candidate] (98.07 ms) : 0, 98070
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~3c3a0c57aa, baseline=1.57.0-SNAPSHOT~823cec6aa6
dateFormat X
axisFormat %s
section baseline
no_agent (17.954 ms) : 17773, 18135
. : milestone, 17954,
appsec (18.717 ms) : 18526, 18908
. : milestone, 18717,
code_origins (17.568 ms) : 17392, 17744
. : milestone, 17568,
iast (18.054 ms) : 17874, 18234
. : milestone, 18054,
profiling (18.322 ms) : 18142, 18502
. : milestone, 18322,
tracing (17.896 ms) : 17718, 18075
. : milestone, 17896,
section candidate
no_agent (18.988 ms) : 18796, 19180
. : milestone, 18988,
appsec (18.822 ms) : 18626, 19018
. : milestone, 18822,
code_origins (17.811 ms) : 17634, 17988
. : milestone, 17811,
iast (17.986 ms) : 17804, 18169
. : milestone, 17986,
profiling (18.891 ms) : 18702, 19080
. : milestone, 18891,
tracing (17.731 ms) : 17555, 17907
. : milestone, 17731,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~3c3a0c57aa, baseline=1.57.0-SNAPSHOT~823cec6aa6
dateFormat X
axisFormat %s
section baseline
no_agent (1.206 ms) : 1194, 1218
. : milestone, 1206,
iast (3.212 ms) : 3164, 3260
. : milestone, 3212,
iast_FULL (5.701 ms) : 5644, 5758
. : milestone, 5701,
iast_GLOBAL (3.53 ms) : 3485, 3575
. : milestone, 3530,
profiling (1.931 ms) : 1915, 1948
. : milestone, 1931,
tracing (1.8 ms) : 1786, 1815
. : milestone, 1800,
section candidate
no_agent (1.196 ms) : 1184, 1207
. : milestone, 1196,
iast (3.26 ms) : 3213, 3308
. : milestone, 3260,
iast_FULL (5.723 ms) : 5667, 5779
. : milestone, 5723,
iast_GLOBAL (3.64 ms) : 3587, 3693
. : milestone, 3640,
profiling (2.166 ms) : 2146, 2186
. : milestone, 2166,
tracing (1.867 ms) : 1851, 1883
. : milestone, 1867,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~3c3a0c57aa, baseline=1.57.0-SNAPSHOT~823cec6aa6
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.728 ms) : 3509, 3947
. : milestone, 3728,
iast (2.224 ms) : 2159, 2289
. : milestone, 2224,
iast_GLOBAL (2.279 ms) : 2214, 2345
. : milestone, 2279,
profiling (2.071 ms) : 2019, 2124
. : milestone, 2071,
tracing (2.061 ms) : 2009, 2112
. : milestone, 2061,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.655 ms) : 3440, 3870
. : milestone, 3655,
iast (2.224 ms) : 2159, 2289
. : milestone, 2224,
iast_GLOBAL (2.269 ms) : 2204, 2335
. : milestone, 2269,
profiling (2.079 ms) : 2026, 2133
. : milestone, 2079,
tracing (2.053 ms) : 2002, 2104
. : milestone, 2053,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~3c3a0c57aa, baseline=1.57.0-SNAPSHOT~823cec6aa6
dateFormat X
axisFormat %s
section baseline
no_agent (15.634 s) : 15634000, 15634000
. : milestone, 15634000,
appsec (14.513 s) : 14513000, 14513000
. : milestone, 14513000,
iast (18.363 s) : 18363000, 18363000
. : milestone, 18363000,
iast_GLOBAL (18.197 s) : 18197000, 18197000
. : milestone, 18197000,
profiling (14.628 s) : 14628000, 14628000
. : milestone, 14628000,
tracing (14.566 s) : 14566000, 14566000
. : milestone, 14566000,
section candidate
no_agent (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
appsec (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
iast (18.116 s) : 18116000, 18116000
. : milestone, 18116000,
iast_GLOBAL (17.857 s) : 17857000, 17857000
. : milestone, 17857000,
profiling (14.728 s) : 14728000, 14728000
. : milestone, 14728000,
tracing (14.547 s) : 14547000, 14547000
. : milestone, 14547000,
|
What Does This Do
As part of the process of migrating to a V2
supported-configurations.jsonformat, I added logging to each call inConfigProviderthat queried theConfigHelperto generate documentation on the configs in the tracer. This led to discoveries of some inaccuracies, particularly with aliases, that are addressed in this PR.Additionally, this PR cleans up configs that are not referenced at all in the library, restructures the
add.span.pointerssuffix to remove it as a config definition, and renamesDD_UNDERTOW_CONTINUATIONto prevent devs from confusing it as a config (used as a key in instrumentation, not actually a config).With this updated local file, we can properly generate documentation for these configurations in #10078 (WIP) and officially "migrate" to the v2 format.
Note that many of the
*_PROPAGATION_*configs were falsely listed as unique env vars when they are actually aliases. Thus, they were removed from thesupportedConfigurationskey and added to thealiaseskey instead.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]