-
Notifications
You must be signed in to change notification settings - Fork 319
Enable Spotbugs and Spotless for modules that require JDK21+.
#10092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enable Spotbugs and Spotless for modules that require JDK21+.
#10092
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~4a6c08e838, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089661
Total [baseline] (10.83 s) : 0, 10830434
Agent [candidate] (1.083 s) : 0, 1082924
Total [candidate] (10.79 s) : 0, 10789738
section appsec
Agent [baseline] (1.266 s) : 0, 1265964
Total [baseline] (11.159 s) : 0, 11159438
Agent [candidate] (1.277 s) : 0, 1277244
Total [candidate] (11.141 s) : 0, 11141062
section iast
Agent [baseline] (1.233 s) : 0, 1233080
Total [baseline] (11.182 s) : 0, 11182416
Agent [candidate] (1.22 s) : 0, 1220410
Total [candidate] (11.171 s) : 0, 11171244
section profiling
Agent [baseline] (1.206 s) : 0, 1205720
Total [baseline] (11.104 s) : 0, 11103506
Agent [candidate] (1.204 s) : 0, 1203649
Total [candidate] (11.057 s) : 0, 11057147
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~4a6c08e838, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (653.568 ms) : 0, 653568
BytebuddyAgent [candidate] (649.271 ms) : 0, 649271
GlobalTracer [baseline] (284.254 ms) : 0, 284254
GlobalTracer [candidate] (282.742 ms) : 0, 282742
AppSec [baseline] (32.747 ms) : 0, 32747
AppSec [candidate] (32.333 ms) : 0, 32333
Debugger [baseline] (68.578 ms) : 0, 68578
Debugger [candidate] (67.475 ms) : 0, 67475
Remote Config [baseline] (634.947 µs) : 0, 635
Remote Config [candidate] (645.319 µs) : 0, 645
Telemetry [baseline] (9.053 ms) : 0, 9053
Telemetry [candidate] (9.926 ms) : 0, 9926
Flare Poller [baseline] (3.822 ms) : 0, 3822
Flare Poller [candidate] (3.694 ms) : 0, 3694
section appsec
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (689.798 ms) : 0, 689798
BytebuddyAgent [candidate] (696.203 ms) : 0, 696203
GlobalTracer [baseline] (259.433 ms) : 0, 259433
GlobalTracer [candidate] (262.403 ms) : 0, 262403
AppSec [baseline] (175.084 ms) : 0, 175084
AppSec [candidate] (175.482 ms) : 0, 175482
Debugger [baseline] (66.564 ms) : 0, 66564
Debugger [candidate] (67.444 ms) : 0, 67444
Remote Config [baseline] (748.26 µs) : 0, 748
Remote Config [candidate] (706.241 µs) : 0, 706
Telemetry [baseline] (8.97 ms) : 0, 8970
Telemetry [candidate] (8.971 ms) : 0, 8971
Flare Poller [baseline] (3.965 ms) : 0, 3965
Flare Poller [candidate] (3.919 ms) : 0, 3919
IAST [baseline] (24.639 ms) : 0, 24639
IAST [candidate] (25.173 ms) : 0, 25173
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (797.849 ms) : 0, 797849
BytebuddyAgent [candidate] (789.426 ms) : 0, 789426
GlobalTracer [baseline] (257.252 ms) : 0, 257252
GlobalTracer [candidate] (254.289 ms) : 0, 254289
AppSec [baseline] (33.626 ms) : 0, 33626
AppSec [candidate] (35.341 ms) : 0, 35341
Debugger [baseline] (66.905 ms) : 0, 66905
Debugger [candidate] (65.394 ms) : 0, 65394
Remote Config [baseline] (548.251 µs) : 0, 548
Remote Config [candidate] (555.123 µs) : 0, 555
Telemetry [baseline] (8.498 ms) : 0, 8498
Telemetry [candidate] (8.446 ms) : 0, 8446
Flare Poller [baseline] (3.465 ms) : 0, 3465
Flare Poller [candidate] (3.464 ms) : 0, 3464
IAST [baseline] (28.082 ms) : 0, 28082
IAST [candidate] (26.923 ms) : 0, 26923
section profiling
ProfilingAgent [baseline] (98.167 ms) : 0, 98167
ProfilingAgent [candidate] (97.645 ms) : 0, 97645
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (701.249 ms) : 0, 701249
BytebuddyAgent [candidate] (700.463 ms) : 0, 700463
GlobalTracer [baseline] (221.065 ms) : 0, 221065
GlobalTracer [candidate] (220.899 ms) : 0, 220899
AppSec [baseline] (32.268 ms) : 0, 32268
AppSec [candidate] (32.207 ms) : 0, 32207
Debugger [baseline] (68.459 ms) : 0, 68459
Debugger [candidate] (68.116 ms) : 0, 68116
Remote Config [baseline] (651.596 µs) : 0, 652
Remote Config [candidate] (639.289 µs) : 0, 639
Telemetry [baseline] (9.08 ms) : 0, 9080
Telemetry [candidate] (8.989 ms) : 0, 8989
Flare Poller [baseline] (3.804 ms) : 0, 3804
Flare Poller [candidate] (3.784 ms) : 0, 3784
Profiling [baseline] (98.81 ms) : 0, 98810
Profiling [candidate] (98.244 ms) : 0, 98244
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~4a6c08e838, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078285
Total [baseline] (8.711 s) : 0, 8711053
Agent [candidate] (1.094 s) : 0, 1094338
Total [candidate] (8.76 s) : 0, 8759914
section iast
Agent [baseline] (1.232 s) : 0, 1232354
Total [baseline] (9.513 s) : 0, 9512660
Agent [candidate] (1.219 s) : 0, 1218990
Total [candidate] (9.496 s) : 0, 9496161
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~4a6c08e838, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (646.992 ms) : 0, 646992
BytebuddyAgent [candidate] (657.185 ms) : 0, 657185
GlobalTracer [baseline] (281.432 ms) : 0, 281432
GlobalTracer [candidate] (285.221 ms) : 0, 285221
AppSec [baseline] (32.218 ms) : 0, 32218
AppSec [candidate] (33.081 ms) : 0, 33081
Debugger [baseline] (67.628 ms) : 0, 67628
Debugger [candidate] (68.151 ms) : 0, 68151
Remote Config [baseline] (640.674 µs) : 0, 641
Remote Config [candidate] (662.509 µs) : 0, 663
Telemetry [baseline] (8.924 ms) : 0, 8924
Telemetry [candidate] (9.075 ms) : 0, 9075
Flare Poller [baseline] (3.691 ms) : 0, 3691
Flare Poller [candidate] (3.806 ms) : 0, 3806
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (797.066 ms) : 0, 797066
BytebuddyAgent [candidate] (788.851 ms) : 0, 788851
GlobalTracer [baseline] (257.108 ms) : 0, 257108
GlobalTracer [candidate] (254.842 ms) : 0, 254842
IAST [baseline] (27.385 ms) : 0, 27385
IAST [candidate] (26.73 ms) : 0, 26730
AppSec [baseline] (35.612 ms) : 0, 35612
AppSec [candidate] (35.375 ms) : 0, 35375
Debugger [baseline] (65.544 ms) : 0, 65544
Debugger [candidate] (64.261 ms) : 0, 64261
Remote Config [baseline] (576.924 µs) : 0, 577
Remote Config [candidate] (533.237 µs) : 0, 533
Telemetry [baseline] (8.56 ms) : 0, 8560
Telemetry [candidate] (8.385 ms) : 0, 8385
Flare Poller [baseline] (3.52 ms) : 0, 3520
Flare Poller [candidate] (3.379 ms) : 0, 3379
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 15 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~4a6c08e838, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (1.202 ms) : 1191, 1213
. : milestone, 1202,
iast (3.345 ms) : 3299, 3390
. : milestone, 3345,
iast_FULL (5.686 ms) : 5629, 5742
. : milestone, 5686,
iast_GLOBAL (3.669 ms) : 3605, 3734
. : milestone, 3669,
profiling (2.077 ms) : 2058, 2097
. : milestone, 2077,
tracing (1.777 ms) : 1762, 1792
. : milestone, 1777,
section candidate
no_agent (1.177 ms) : 1165, 1188
. : milestone, 1177,
iast (3.109 ms) : 3066, 3151
. : milestone, 3109,
iast_FULL (5.551 ms) : 5496, 5606
. : milestone, 5551,
iast_GLOBAL (3.65 ms) : 3596, 3704
. : milestone, 3650,
profiling (1.997 ms) : 1980, 2014
. : milestone, 1997,
tracing (1.843 ms) : 1827, 1860
. : milestone, 1843,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~4a6c08e838, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (19.855 ms) : 19649, 20061
. : milestone, 19855,
appsec (18.557 ms) : 18368, 18745
. : milestone, 18557,
code_origins (17.61 ms) : 17436, 17784
. : milestone, 17610,
iast (17.708 ms) : 17531, 17884
. : milestone, 17708,
profiling (18.556 ms) : 18375, 18738
. : milestone, 18556,
tracing (17.805 ms) : 17625, 17986
. : milestone, 17805,
section candidate
no_agent (18.322 ms) : 18132, 18513
. : milestone, 18322,
appsec (18.741 ms) : 18550, 18933
. : milestone, 18741,
code_origins (17.792 ms) : 17616, 17968
. : milestone, 17792,
iast (17.992 ms) : 17812, 18172
. : milestone, 17992,
profiling (18.402 ms) : 18218, 18586
. : milestone, 18402,
tracing (17.608 ms) : 17430, 17785
. : milestone, 17608,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~4a6c08e838, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.723 ms) : 3503, 3942
. : milestone, 3723,
iast (2.204 ms) : 2140, 2269
. : milestone, 2204,
iast_GLOBAL (2.259 ms) : 2194, 2325
. : milestone, 2259,
profiling (2.09 ms) : 2035, 2144
. : milestone, 2090,
tracing (2.05 ms) : 1999, 2101
. : milestone, 2050,
section candidate
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.646 ms) : 3433, 3859
. : milestone, 3646,
iast (2.211 ms) : 2146, 2277
. : milestone, 2211,
iast_GLOBAL (2.256 ms) : 2191, 2321
. : milestone, 2256,
profiling (2.072 ms) : 2019, 2126
. : milestone, 2072,
tracing (2.049 ms) : 1997, 2101
. : milestone, 2049,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~4a6c08e838, baseline=1.57.0-SNAPSHOT~89639f7e8c
dateFormat X
axisFormat %s
section baseline
no_agent (15.465 s) : 15465000, 15465000
. : milestone, 15465000,
appsec (14.526 s) : 14526000, 14526000
. : milestone, 14526000,
iast (18.174 s) : 18174000, 18174000
. : milestone, 18174000,
iast_GLOBAL (17.915 s) : 17915000, 17915000
. : milestone, 17915000,
profiling (15.46 s) : 15460000, 15460000
. : milestone, 15460000,
tracing (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
section candidate
no_agent (15.023 s) : 15023000, 15023000
. : milestone, 15023000,
appsec (14.564 s) : 14564000, 14564000
. : milestone, 14564000,
iast (18.335 s) : 18335000, 18335000
. : milestone, 18335000,
iast_GLOBAL (18.316 s) : 18316000, 18316000
. : milestone, 18316000,
profiling (15.214 s) : 15214000, 15214000
. : milestone, 15214000,
tracing (14.986 s) : 14986000, 14986000
. : milestone, 14986000,
|
sarahchen6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay
What Does This Do
Enable
SpotbugsandSpotlessfor modules that require JDK21+.Motivation
Apply tools to whole code base.
Additional Notes
Previously those tools not worked correctly with latest JDKs, now they are.