Only enable client side stats if the host agent is at least 7.65.0 #10041

bric3 · 2025-11-27T10:08:04Z

What Does This Do

Only enable client side stats when the agent is at least 7.65.0.

Motivation

The reason is that container based primary tags are not supported by earlier versions of the host agent and as such can't be reported when CSS is enabled.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-11-27T10:53:18Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/enable-css-only-after-agent-7.65.0
git_commit_date	1764948592	1764955510
git_commit_sha	`89639f7`	`71829fa`
release_version	1.57.0-SNAPSHOT~89639f7e8c	1.57.0-SNAPSHOT~71829fa545

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1764957255	1764957255
ci_job_id	1273031053	1273031053
ci_pipeline_id	85045328	85045328
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-2-gveyym2e 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-2-gveyym2e 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~71829fa545, baseline=1.57.0-SNAPSHOT~89639f7e8c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1087770
Total [baseline] (10.951 s) : 0, 10950865
Agent [candidate] (1.082 s) : 0, 1082404
Total [candidate] (10.879 s) : 0, 10878680
section appsec
Agent [baseline] (1.262 s) : 0, 1262199
Total [baseline] (11.112 s) : 0, 11111752
Agent [candidate] (1.266 s) : 0, 1265620
Total [candidate] (11.141 s) : 0, 11141052
section iast
Agent [baseline] (1.223 s) : 0, 1222516
Total [baseline] (11.13 s) : 0, 11129535
Agent [candidate] (1.23 s) : 0, 1229584
Total [candidate] (11.202 s) : 0, 11202135
section profiling
Agent [baseline] (1.203 s) : 0, 1202745
Total [baseline] (11.091 s) : 0, 11090965
Agent [candidate] (1.21 s) : 0, 1210060
Total [candidate] (11.048 s) : 0, 11047962

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	appsec	1.262 s	174.429 ms (16.0%)
Agent	iast	1.223 s	134.746 ms (12.4%)
Agent	profiling	1.203 s	114.975 ms (10.6%)
Total	tracing	10.951 s	-
Total	appsec	11.112 s	160.888 ms (1.5%)
Total	iast	11.13 s	178.67 ms (1.6%)
Total	profiling	11.091 s	140.1 ms (1.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.082 s	-
Agent	appsec	1.266 s	183.216 ms (16.9%)
Agent	iast	1.23 s	147.18 ms (13.6%)
Agent	profiling	1.21 s	127.656 ms (11.8%)
Total	tracing	10.879 s	-
Total	appsec	11.141 s	262.373 ms (2.4%)
Total	iast	11.202 s	323.456 ms (3.0%)
Total	profiling	11.048 s	169.283 ms (1.6%)

gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~71829fa545, baseline=1.57.0-SNAPSHOT~89639f7e8c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (652.298 ms) : 0, 652298
BytebuddyAgent [candidate] (649.168 ms) : 0, 649168
GlobalTracer [baseline] (283.426 ms) : 0, 283426
GlobalTracer [candidate] (282.57 ms) : 0, 282570
AppSec [baseline] (32.501 ms) : 0, 32501
AppSec [candidate] (32.384 ms) : 0, 32384
Debugger [baseline] (69.095 ms) : 0, 69095
Debugger [candidate] (68.168 ms) : 0, 68168
Remote Config [baseline] (654.755 µs) : 0, 655
Remote Config [candidate] (645.513 µs) : 0, 646
Telemetry [baseline] (8.994 ms) : 0, 8994
Telemetry [candidate] (8.945 ms) : 0, 8945
Flare Poller [baseline] (3.727 ms) : 0, 3727
Flare Poller [candidate] (3.715 ms) : 0, 3715
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.229 ms) : 0, 1229
BytebuddyAgent [baseline] (688.091 ms) : 0, 688091
BytebuddyAgent [candidate] (689.943 ms) : 0, 689943
GlobalTracer [baseline] (258.696 ms) : 0, 258696
GlobalTracer [candidate] (259.317 ms) : 0, 259317
IAST [baseline] (24.433 ms) : 0, 24433
IAST [candidate] (24.522 ms) : 0, 24522
AppSec [baseline] (174.397 ms) : 0, 174397
AppSec [candidate] (174.679 ms) : 0, 174679
Debugger [baseline] (66.43 ms) : 0, 66430
Debugger [candidate] (66.78 ms) : 0, 66780
Remote Config [baseline] (699.553 µs) : 0, 700
Remote Config [candidate] (704.038 µs) : 0, 704
Telemetry [baseline] (8.858 ms) : 0, 8858
Telemetry [candidate] (8.805 ms) : 0, 8805
Flare Poller [baseline] (3.844 ms) : 0, 3844
Flare Poller [candidate] (3.87 ms) : 0, 3870
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (790.569 ms) : 0, 790569
BytebuddyAgent [candidate] (793.239 ms) : 0, 793239
GlobalTracer [baseline] (254.638 ms) : 0, 254638
GlobalTracer [candidate] (257.441 ms) : 0, 257441
IAST [baseline] (27.032 ms) : 0, 27032
IAST [candidate] (27.14 ms) : 0, 27140
AppSec [baseline] (35.232 ms) : 0, 35232
AppSec [candidate] (35.467 ms) : 0, 35467
Debugger [baseline] (65.901 ms) : 0, 65901
Debugger [candidate] (66.868 ms) : 0, 66868
Remote Config [baseline] (559.096 µs) : 0, 559
Remote Config [candidate] (573.054 µs) : 0, 573
Telemetry [baseline] (8.435 ms) : 0, 8435
Telemetry [candidate] (8.623 ms) : 0, 8623
Flare Poller [baseline] (3.441 ms) : 0, 3441
Flare Poller [candidate] (3.548 ms) : 0, 3548
section profiling
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (700.495 ms) : 0, 700495
BytebuddyAgent [candidate] (703.8 ms) : 0, 703800
GlobalTracer [baseline] (220.462 ms) : 0, 220462
GlobalTracer [candidate] (222.337 ms) : 0, 222337
AppSec [baseline] (32.113 ms) : 0, 32113
AppSec [candidate] (32.54 ms) : 0, 32540
Debugger [baseline] (68.335 ms) : 0, 68335
Debugger [candidate] (68.902 ms) : 0, 68902
Remote Config [baseline] (642.305 µs) : 0, 642
Remote Config [candidate] (644.149 µs) : 0, 644
Telemetry [baseline] (8.865 ms) : 0, 8865
Telemetry [candidate] (9.052 ms) : 0, 9052
Flare Poller [baseline] (3.728 ms) : 0, 3728
Flare Poller [candidate] (3.786 ms) : 0, 3786
ProfilingAgent [baseline] (97.397 ms) : 0, 97397
ProfilingAgent [candidate] (98.061 ms) : 0, 98061
Profiling [baseline] (97.967 ms) : 0, 97967
Profiling [candidate] (98.648 ms) : 0, 98648

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~71829fa545, baseline=1.57.0-SNAPSHOT~89639f7e8c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080052
Total [baseline] (8.747 s) : 0, 8746597
Agent [candidate] (1.089 s) : 0, 1088951
Total [candidate] (8.756 s) : 0, 8756418
section iast
Agent [baseline] (1.232 s) : 0, 1231540
Total [baseline] (9.466 s) : 0, 9466155
Agent [candidate] (1.222 s) : 0, 1221901
Total [candidate] (9.493 s) : 0, 9493387

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.08 s	-
Agent	iast	1.232 s	151.488 ms (14.0%)
Total	tracing	8.747 s	-
Total	iast	9.466 s	719.558 ms (8.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.089 s	-
Agent	iast	1.222 s	132.951 ms (12.2%)
Total	tracing	8.756 s	-
Total	iast	9.493 s	736.969 ms (8.4%)

gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~71829fa545, baseline=1.57.0-SNAPSHOT~89639f7e8c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (647.774 ms) : 0, 647774
BytebuddyAgent [candidate] (653.972 ms) : 0, 653972
GlobalTracer [baseline] (281.692 ms) : 0, 281692
GlobalTracer [candidate] (283.974 ms) : 0, 283974
AppSec [baseline] (32.523 ms) : 0, 32523
AppSec [candidate] (32.809 ms) : 0, 32809
Debugger [baseline] (67.769 ms) : 0, 67769
Debugger [candidate] (67.834 ms) : 0, 67834
Remote Config [baseline] (648.612 µs) : 0, 649
Remote Config [candidate] (647.849 µs) : 0, 648
Telemetry [baseline] (9.049 ms) : 0, 9049
Telemetry [candidate] (8.985 ms) : 0, 8985
Flare Poller [baseline] (3.801 ms) : 0, 3801
Flare Poller [candidate] (3.721 ms) : 0, 3721
section iast
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (797.654 ms) : 0, 797654
BytebuddyAgent [candidate] (789.9 ms) : 0, 789900
GlobalTracer [baseline] (256.899 ms) : 0, 256899
GlobalTracer [candidate] (255.892 ms) : 0, 255892
IAST [baseline] (27.153 ms) : 0, 27153
IAST [candidate] (26.988 ms) : 0, 26988
AppSec [baseline] (35.659 ms) : 0, 35659
AppSec [candidate] (35.611 ms) : 0, 35611
Debugger [baseline] (64.961 ms) : 0, 64961
Debugger [candidate] (64.465 ms) : 0, 64465
Remote Config [baseline] (547.565 µs) : 0, 548
Remote Config [candidate] (543.225 µs) : 0, 543
Telemetry [baseline] (8.402 ms) : 0, 8402
Telemetry [candidate] (8.413 ms) : 0, 8413
Flare Poller [baseline] (3.433 ms) : 0, 3433
Flare Poller [candidate] (3.456 ms) : 0, 3456

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/enable-css-only-after-agent-7.65.0
git_commit_date	1764948592	1764955510
git_commit_sha	`89639f7`	`71829fa`
release_version	1.57.0-SNAPSHOT~89639f7e8c	1.57.0-SNAPSHOT~71829fa545

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1764957817	1764957817
ci_job_id	1273031054	1273031054
ci_pipeline_id	85045328	85045328
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-xmb8w644 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-xmb8w644 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 5 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load	worse [+142.926µs; +385.242µs] or [+2.867%; +7.728%]	worse [+416.280µs; +1085.957µs] or [+3.553%; +9.269%]	unstable [-133.105op/s; +31.855op/s] or [-16.094%; +3.852%]	5.249ms	12.467ms	776.438op/s	4.985ms	11.716ms	827.062op/s
scenario:load:petclinic:iast:high_load	better [-1.854ms; -0.813ms] or [-9.910%; -4.348%]	unsure [-1.788ms; -0.242ms] or [-5.953%; -0.804%]	unstable [-13.462op/s; +42.274op/s] or [-5.425%; +17.038%]	17.373ms	29.023ms	262.531op/s	18.706ms	30.037ms	248.125op/s
scenario:load:petclinic:appsec:high_load	worse [+0.836ms; +1.560ms] or [+4.618%; +8.615%]	unsure [+253.632µs; +1595.724µs] or [+0.843%; +5.301%]	unstable [-39.763op/s; +13.326op/s] or [-15.834%; +5.306%]	19.306ms	31.028ms	237.906op/s	18.108ms	30.103ms	251.125op/s
scenario:load:petclinic:profiling:high_load	worse [+0.676ms; +1.519ms] or [+3.676%; +8.256%]	worse [+0.862ms; +2.573ms] or [+2.903%; +8.661%]	unstable [-40.072op/s; +12.635op/s] or [-16.065%; +5.065%]	19.496ms	31.421ms	235.719op/s	18.399ms	29.703ms	249.438op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~71829fa545, baseline=1.57.0-SNAPSHOT~89639f7e8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.202 ms) : 1191, 1214
.   : milestone, 1202,
iast (3.052 ms) : 3020, 3085
.   : milestone, 3052,
iast_FULL (5.588 ms) : 5534, 5642
.   : milestone, 5588,
iast_GLOBAL (3.589 ms) : 3538, 3641
.   : milestone, 3589,
profiling (2.156 ms) : 2136, 2176
.   : milestone, 2156,
tracing (1.769 ms) : 1755, 1784
.   : milestone, 1769,
section candidate
no_agent (1.304 ms) : 1290, 1318
.   : milestone, 1304,
iast (3.174 ms) : 3131, 3217
.   : milestone, 3174,
iast_FULL (5.955 ms) : 5895, 6015
.   : milestone, 5955,
iast_GLOBAL (3.592 ms) : 3540, 3645
.   : milestone, 3592,
profiling (1.955 ms) : 1939, 1971
.   : milestone, 1955,
tracing (1.823 ms) : 1808, 1839
.   : milestone, 1823,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.202 ms [1.191 ms, 1.214 ms]	-
iast	3.052 ms [3.02 ms, 3.085 ms]	1.85 ms (153.9%)
iast_FULL	5.588 ms [5.534 ms, 5.642 ms]	4.386 ms (364.7%)
iast_GLOBAL	3.589 ms [3.538 ms, 3.641 ms]	2.387 ms (198.5%)
profiling	2.156 ms [2.136 ms, 2.176 ms]	953.941 µs (79.3%)
tracing	1.769 ms [1.755 ms, 1.784 ms]	566.962 µs (47.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.304 ms [1.29 ms, 1.318 ms]	-
iast	3.174 ms [3.131 ms, 3.217 ms]	1.87 ms (143.4%)
iast_FULL	5.955 ms [5.895 ms, 6.015 ms]	4.651 ms (356.6%)
iast_GLOBAL	3.592 ms [3.54 ms, 3.645 ms]	2.288 ms (175.4%)
profiling	1.955 ms [1.939 ms, 1.971 ms]	650.452 µs (49.9%)
tracing	1.823 ms [1.808 ms, 1.839 ms]	518.927 µs (39.8%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~71829fa545, baseline=1.57.0-SNAPSHOT~89639f7e8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.304 ms) : 18116, 18492
.   : milestone, 18304,
appsec (18.585 ms) : 18395, 18775
.   : milestone, 18585,
code_origins (17.505 ms) : 17334, 17676
.   : milestone, 17505,
iast (18.811 ms) : 18621, 19001
.   : milestone, 18811,
profiling (18.707 ms) : 18520, 18894
.   : milestone, 18707,
tracing (17.56 ms) : 17389, 17731
.   : milestone, 17560,
section candidate
no_agent (19.189 ms) : 18990, 19388
.   : milestone, 19189,
appsec (19.621 ms) : 19418, 19823
.   : milestone, 19621,
code_origins (17.647 ms) : 17471, 17824
.   : milestone, 17647,
iast (17.77 ms) : 17591, 17950
.   : milestone, 17770,
profiling (19.808 ms) : 19604, 20011
.   : milestone, 19808,
tracing (17.635 ms) : 17460, 17809
.   : milestone, 17635,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.304 ms [18.116 ms, 18.492 ms]	-
appsec	18.585 ms [18.395 ms, 18.775 ms]	281.202 µs (1.5%)
code_origins	17.505 ms [17.334 ms, 17.676 ms]	-798.973 µs (-4.4%)
iast	18.811 ms [18.621 ms, 19.001 ms]	507.417 µs (2.8%)
profiling	18.707 ms [18.52 ms, 18.894 ms]	403.025 µs (2.2%)
tracing	17.56 ms [17.389 ms, 17.731 ms]	-744.17 µs (-4.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.189 ms [18.99 ms, 19.388 ms]	-
appsec	19.621 ms [19.418 ms, 19.823 ms]	431.797 µs (2.3%)
code_origins	17.647 ms [17.471 ms, 17.824 ms]	-1.541 ms (-8.0%)
iast	17.77 ms [17.591 ms, 17.95 ms]	-1.418 ms (-7.4%)
profiling	19.808 ms [19.604 ms, 20.011 ms]	619.191 µs (3.2%)
tracing	17.635 ms [17.46 ms, 17.809 ms]	-1.554 ms (-8.1%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/enable-css-only-after-agent-7.65.0
git_commit_date	1764948592	1764955510
git_commit_sha	`89639f7`	`71829fa`
release_version	1.57.0-SNAPSHOT~89639f7e8c	1.57.0-SNAPSHOT~71829fa545

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1764957719	1764957719
ci_job_id	1273031055	1273031055
ci_pipeline_id	85045328	85045328
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-3-8416slb7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-3-8416slb7 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~71829fa545, baseline=1.57.0-SNAPSHOT~89639f7e8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.754 s) : 14754000, 14754000
.   : milestone, 14754000,
appsec (14.345 s) : 14345000, 14345000
.   : milestone, 14345000,
iast (18.121 s) : 18121000, 18121000
.   : milestone, 18121000,
iast_GLOBAL (17.953 s) : 17953000, 17953000
.   : milestone, 17953000,
profiling (14.569 s) : 14569000, 14569000
.   : milestone, 14569000,
tracing (14.797 s) : 14797000, 14797000
.   : milestone, 14797000,
section candidate
no_agent (14.894 s) : 14894000, 14894000
.   : milestone, 14894000,
appsec (14.702 s) : 14702000, 14702000
.   : milestone, 14702000,
iast (18.128 s) : 18128000, 18128000
.   : milestone, 18128000,
iast_GLOBAL (18.084 s) : 18084000, 18084000
.   : milestone, 18084000,
profiling (14.71 s) : 14710000, 14710000
.   : milestone, 14710000,
tracing (14.784 s) : 14784000, 14784000
.   : milestone, 14784000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.754 s [14.754 s, 14.754 s]	-
appsec	14.345 s [14.345 s, 14.345 s]	-409.0 ms (-2.8%)
iast	18.121 s [18.121 s, 18.121 s]	3.367 s (22.8%)
iast_GLOBAL	17.953 s [17.953 s, 17.953 s]	3.199 s (21.7%)
profiling	14.569 s [14.569 s, 14.569 s]	-185.0 ms (-1.3%)
tracing	14.797 s [14.797 s, 14.797 s]	43.0 ms (0.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.894 s [14.894 s, 14.894 s]	-
appsec	14.702 s [14.702 s, 14.702 s]	-192.0 ms (-1.3%)
iast	18.128 s [18.128 s, 18.128 s]	3.234 s (21.7%)
iast_GLOBAL	18.084 s [18.084 s, 18.084 s]	3.19 s (21.4%)
profiling	14.71 s [14.71 s, 14.71 s]	-184.0 ms (-1.2%)
tracing	14.784 s [14.784 s, 14.784 s]	-110.0 ms (-0.7%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~71829fa545, baseline=1.57.0-SNAPSHOT~89639f7e8c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.487 ms) : 1475, 1499
.   : milestone, 1487,
appsec (3.722 ms) : 3503, 3940
.   : milestone, 3722,
iast (2.22 ms) : 2155, 2285
.   : milestone, 2220,
iast_GLOBAL (2.273 ms) : 2208, 2338
.   : milestone, 2273,
profiling (2.098 ms) : 2044, 2152
.   : milestone, 2098,
tracing (2.056 ms) : 2004, 2107
.   : milestone, 2056,
section candidate
no_agent (1.478 ms) : 1466, 1489
.   : milestone, 1478,
appsec (3.721 ms) : 3503, 3939
.   : milestone, 3721,
iast (2.224 ms) : 2159, 2288
.   : milestone, 2224,
iast_GLOBAL (2.26 ms) : 2195, 2325
.   : milestone, 2260,
profiling (2.106 ms) : 2052, 2160
.   : milestone, 2106,
tracing (2.049 ms) : 1998, 2100
.   : milestone, 2049,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.487 ms [1.475 ms, 1.499 ms]	-
appsec	3.722 ms [3.503 ms, 3.94 ms]	2.234 ms (150.3%)
iast	2.22 ms [2.155 ms, 2.285 ms]	733.206 µs (49.3%)
iast_GLOBAL	2.273 ms [2.208 ms, 2.338 ms]	785.819 µs (52.8%)
profiling	2.098 ms [2.044 ms, 2.152 ms]	610.451 µs (41.0%)
tracing	2.056 ms [2.004 ms, 2.107 ms]	568.641 µs (38.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.489 ms]	-
appsec	3.721 ms [3.503 ms, 3.939 ms]	2.244 ms (151.8%)
iast	2.224 ms [2.159 ms, 2.288 ms]	745.622 µs (50.5%)
iast_GLOBAL	2.26 ms [2.195 ms, 2.325 ms]	782.163 µs (52.9%)
profiling	2.106 ms [2.052 ms, 2.16 ms]	627.924 µs (42.5%)
tracing	2.049 ms [1.998 ms, 2.1 ms]	571.179 µs (38.6%)

communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java

amarziali

thanks for the fix

bric3 · 2025-11-27T16:46:39Z

Currently blocked on system tests, because the test agent version is hardcoded to test, see

https://github.com/DataDog/dd-apm-test-agent/blob/fd46ab609a48ac2935f8b4d55a122b8530e1cb73/ddapm_test_agent/agent.py#L886-L887

…-after-agent-7.65.0

raphaelgavache · 2025-12-05T20:09:19Z

communication/src/main/java/datadog/communication/ddagent/AgentVersion.java

+      // Assumes the 'version' is below if it can't be parsed.
+      int majorDot = version.indexOf('.');
+      if (majorDot == -1) {
+        return true;


there's a potential mistake
shouldn't it be the opposite: custom agent builds would be assumed to be more recent. The comment at the top of the function describes it correctly

false otherwise (including when version is null or unparseable)

raphaelgavache · 2025-12-05T20:09:28Z

communication/src/main/java/datadog/communication/ddagent/AgentVersion.java

+   */
+  public static boolean isVersionBelow(String version, int maxMajor, int maxMinor, int maxPatch) {
+    if (version == null || version.isEmpty()) {
+      return true;


same as below

bric3 requested a review from a team as a code owner November 27, 2025 10:08

bric3 requested review from amarziali and ygree November 27, 2025 10:08

bric3 added type: bug Bug report and fix comp: metrics Metrics labels Nov 27, 2025

amarziali reviewed Nov 27, 2025

View reviewed changes

communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java Outdated Show resolved Hide resolved

fix: Only enable client side stats if the host agent is at least 7.65.0

5f0a764

bric3 force-pushed the bdu/enable-css-only-after-agent-7.65.0 branch from 35b0813 to 414bb53 Compare November 27, 2025 13:55

amarziali reviewed Nov 27, 2025

View reviewed changes

communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java Outdated Show resolved Hide resolved

amarziali reviewed Nov 27, 2025

View reviewed changes

communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java Show resolved Hide resolved

fix: PR review, moved version check outside hotpath

c08baa1

bric3 force-pushed the bdu/enable-css-only-after-agent-7.65.0 branch from 414bb53 to c08baa1 Compare November 27, 2025 14:08

amarziali approved these changes Nov 27, 2025

View reviewed changes

bric3 mentioned this pull request Dec 4, 2025

fix: Makes the test agent report version 7.65.0 for client side stats DataDog/system-tests#5823

Merged

6 tasks

Merge remote-tracking branch 'origin/master' into bdu/enable-css-only…

aec4371

…-after-agent-7.65.0

bric3 had a problem deploying to ci-build December 5, 2025 17:01 — with GitHub Actions Error

fix: Use the revert check isVersionAtLeast -> isVersionBelow

110d9c9

bric3 temporarily deployed to ci-build December 5, 2025 17:04 — with GitHub Actions Inactive

bric3 mentioned this pull request Dec 5, 2025

Combine client_drop_p0s support and agent version check for CSS #10046

Open

chore: Make spotless happy

71829fa

bric3 enabled auto-merge (squash) December 5, 2025 17:35

bric3 temporarily deployed to ci-build December 5, 2025 17:38 — with GitHub Actions Inactive

raphaelgavache reviewed Dec 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Only enable client side stats if the host agent is at least 7.65.0 #10041

Only enable client side stats if the host agent is at least 7.65.0 #10041

Uh oh!

bric3 commented Nov 27, 2025

Uh oh!

pr-commenter bot commented Nov 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amarziali left a comment

Uh oh!

bric3 commented Nov 27, 2025

Uh oh!

raphaelgavache Dec 5, 2025

Uh oh!

raphaelgavache Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Only enable client side stats if the host agent is at least 7.65.0 #10041

Are you sure you want to change the base?

Only enable client side stats if the host agent is at least 7.65.0 #10041

Uh oh!

Conversation

bric3 commented Nov 27, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amarziali left a comment

Choose a reason for hiding this comment

Uh oh!

bric3 commented Nov 27, 2025

Uh oh!

raphaelgavache Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

raphaelgavache Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pr-commenter bot commented Nov 27, 2025 •

edited

Loading