Skip to content

Conversation

@mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Dec 5, 2025

What does this PR do?

Tracer migrates to using Config's runtimeMetrics and runtimeMetricsV2 instead of its own config.runtimeMetrics and config.runtimeMetricsV2.

Motivation

datadoghq.atlassian.net/browse/APMAPI-1748

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Dec 5, 2025

Benchmarks

Benchmark execution time: 2025-12-09 16:37:46

Comparing candidate commit a437604 in PR branch mtoff/runtime-metrics with baseline commit 78b2dc1 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 6 unstable metrics.

scenario:BenchmarkParallelMetrics/distribution/handle-reused-25

  • 🟥 execution_time [+1.393ns; +7.349ns] or [+2.147%; +11.330%]

@datadog-official
Copy link
Contributor

datadog-official bot commented Dec 5, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a437604 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@kakkoyun kakkoyun changed the title tracer: migrate runtimeMetrics and runtimeMetricsV2 chore(config/tracer): migrate runtimeMetrics and runtimeMetricsV2 Dec 5, 2025
@mtoffl01 mtoffl01 marked this pull request as ready for review December 5, 2025 18:38
@mtoffl01 mtoffl01 requested review from a team as code owners December 5, 2025 18:38
@mtoffl01 mtoffl01 marked this pull request as draft December 5, 2025 19:15
@mtoffl01 mtoffl01 changed the base branch from mtoff/revamp-debug-api to mtoff/config-origin December 5, 2025 19:23
Base automatically changed from mtoff/config-origin to main December 9, 2025 15:38
@mtoffl01 mtoffl01 changed the title chore(config/tracer): migrate runtimeMetrics and runtimeMetricsV2 chore(tracer): migrate runtimeMetrics and runtimeMetricsV2 Dec 9, 2025
@mtoffl01 mtoffl01 marked this pull request as ready for review December 9, 2025 16:36
@mtoffl01 mtoffl01 changed the title chore(tracer): migrate runtimeMetrics and runtimeMetricsV2 chore(config): migrate tracer.runtimeMetrics and tracer.runtimeMetricsV2 Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants