Skip to content

chore: identify candidate dependencies for removal/replacement/absorption #4176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
darccio wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: identify candidate dependencies for removal/replacement/absorption #4176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67fe6c6
chore: identify candidate dependencies for removal/replacement/absorp…
darccio Nov 26, 2025
183054e
chore: update candidate dependencies with current status and decisions
darccio Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,29 @@ require (
github.com/DataDog/go-runtime-metrics-internal v0.0.4-0.20250721125240-fdf1ef85b633
github.com/DataDog/gostackparse v0.7.0
github.com/DataDog/sketches-go v1.4.7
// Replaced partially with golang.org/x/mod/semver in #4182.
github.com/Masterminds/semver/v3 v3.3.1
github.com/cenkalti/backoff/v5 v5.0.3
// To be removed when datadog-agent replaces seelog with slog in https://github.com/DataDog/datadog-agent/pull/43297.
github.com/cihub/seelog v0.0.0-20170130134532-f561c5e57575
// Replaced with custom code in #4181.
github.com/go-viper/mapstructure/v2 v2.4.0
github.com/google/pprof v0.0.0-20241029153458-d1b30febd7db
github.com/google/uuid v1.6.0
// AAP has stated that they have a need for both libraries in https://github.com/DataDog/dd-trace-go/pull/4176#discussion_r2568437568.
github.com/json-iterator/go v1.1.12
github.com/klauspost/compress v1.18.0
github.com/minio/simdjson-go v0.4.5
github.com/open-feature/go-sdk v1.17.0
github.com/puzpuzpuz/xsync/v3 v3.5.1
// Could this one be isolated?
github.com/quasilyte/go-ruleguard/dsl v0.3.22
Copy link
Member Author

@darccio darccio Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kakkoyun Is this dependency needed in the root module?

Copy link
Member

@kakkoyun kakkoyun Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is only needed for the CI check and it's under a build flag. We can experiment how we can remove it from the root module. It's definitely not needed for the runtime, it's a build time dependency.

github.com/richardartoul/molecule v1.0.1-0.20240531184615-7ca0df43c0b3
// spaolacci/murmur3 is from 2019 but it's the most mature and used implementation. Let's keep it.
github.com/spaolacci/murmur3 v1.1.0
// One day we'll remove testify in favour of plain Go. One day in the future :)
github.com/stretchr/testify v1.11.1
// From 2016, only one function used. It looks like a good candidate to absorb into dd-trace-go.
github.com/theckman/httpforwarded v0.4.0
github.com/tinylib/msgp v1.3.0
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.49.0
Expand All @@ -43,7 +51,9 @@ require (
golang.org/x/time v0.12.0
golang.org/x/tools v0.38.0
golang.org/x/xerrors v0.0.0-20231012003039-104605ab7028
// Dependency set to indirect in #4183.
google.golang.org/grpc v1.75.0
// DSM usage makes this a required dependency.
google.golang.org/protobuf v1.36.7
)

Expand Down
Loading