feat(e2e): add Playwright tests for authentication, navigation, and n… #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odes functionality to ensure application reliability chore(playwright): create Playwright configuration file for test setup and execution chore(workflow): add GitHub Actions workflow for running Playwright tests on push and pull request events chore(package): add Playwright as a dependency and update scripts for running e2e tests chore(gitignore): update .gitignore to exclude Playwright reports and test results
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds end-to-end Playwright tests for authentication, navigation, and nodes pages, along with necessary config, scripts, and CI workflow to run them.
- Introduce
playwright.config.tsfor test settings and browser projects - Add E2E test suites under
e2e/covering nodes, navigation, and auth flows - Update
package.jsonscripts and GitHub Actions workflow for running Playwright tests
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| playwright.config.ts | Defines test directory, timeouts, reporters, browsers, and web server settings |
| package.json | Adds test:e2e* scripts and Playwright dependency |
| e2e/nodes.spec.ts | Tests navigation and node detail page interactions |
| e2e/navigation.spec.ts | Tests home page navigation and registry component visibility |
| e2e/auth.spec.ts | Tests sign-in page elements and redirection behavior |
| .github/workflows/playwright.yml | CI job to install deps, browsers, and run Playwright tests |
Comments suppressed due to low confidence (2)
e2e/nodes.spec.ts:30
- If no node cards exist, this test will silently pass. It’s better to assert that at least one node card is present before interacting, e.g.,
await expect(nodeCard).toHaveCountGreaterThan(0).
if (await nodeCard.count() > 0) {
e2e/auth.spec.ts:55
- Key authentication flows (successful and failed logins) are commented out. Consider adding mocked or stubbed auth tests to cover these important scenarios.
// test('should successfully log in with Google and redirect to home')
🎨 Chromatic Visual Testing Results
Check the visual changes and approve or request changes as needed. |
Co-authored-by: Copilot <[email protected]>
🎨 Chromatic Visual Testing Results
Check the visual changes and approve or request changes as needed. |
Member
Author
|
close this as storybook 9.0 have a new feat: "test" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.