-
Notifications
You must be signed in to change notification settings - Fork 6
Added gravity-wave parameters #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ray-chew
wants to merge
3
commits into
main
Choose a base branch
from
rc/gw
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -2920,3 +2920,151 @@ description = "Parameter controlling steepness of (logistic) transition between | |||||
| value = 1e-3 | ||||||
| type = "float" | ||||||
| description = "Parameter controlling exponential scale of favoring cloud top for cloud top calculations (unitless)." | ||||||
|
|
||||||
| # Orographic gravity wave (OGW) | ||||||
| [ogw_mountain_height_width_exponent] | ||||||
| value = 0.4 | ||||||
| type = "float" | ||||||
| description = "Mountain height width exponent (γ), L ∝ h^γ (equation 14, paper suggests γ ≈ 0.4)" | ||||||
|
|
||||||
| [ogw_number_density_exponent] | ||||||
| value = 0.0 | ||||||
| type = "float" | ||||||
| description = "Number density exponent (ϵ), where number density of orography in a grid cell is n(h) ∝ h^(-ε)" | ||||||
|
|
||||||
| [ogw_mountain_shape_parameter] | ||||||
| value = 0.5 | ||||||
| type = "float" | ||||||
| description = "Mountain shape parameter (β), L(z) = L_b(1 - z/h)^β (equation 12), β=1 for triangular mountains and β<1 for blunt mounrains, β>1 for pointy mountains." | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| [ogw_critical_height_threshold] | ||||||
| value = 0.1 | ||||||
| type = "float" | ||||||
| description = "h_crit = h_frac * (V / N), demarcating the split between propagating and non-propagating orographic gravity waves" | ||||||
|
|
||||||
| [ogw_density_scale_factor] | ||||||
| value = 1.2 | ||||||
| type = "float" | ||||||
| description = "Density scale factor (ρscale)" | ||||||
|
|
||||||
| [ogw_reference_mountain_width] | ||||||
| value = 80000.0 | ||||||
| type = "float" | ||||||
| description = "Reference mountain width (L0) in meters" | ||||||
|
|
||||||
| [ogw_linear_drag_coefficient] | ||||||
| value = 0.9 | ||||||
| type = "float" | ||||||
| description = "Linear drag coefficient (a0); (equation 13)" | ||||||
|
|
||||||
| [ogw_nonlinear_drag_coefficient] | ||||||
| value = 3.0 | ||||||
| type = "float" | ||||||
| description = "Nonlinear drag coefficient (a1); equation (13)" | ||||||
|
|
||||||
| [ogw_critical_froude_number] | ||||||
| value = 0.7 | ||||||
| type = "float" | ||||||
| description = "Critical Froude number (Fr_crit) computed from the critical height threshold" | ||||||
|
|
||||||
| # Non-orographic gravity wave (NOGW) | ||||||
|
|
||||||
| [nogw_source_pressure] | ||||||
| value = 31500.0 | ||||||
| type = "float" | ||||||
| description = "Source level pressure (Pa)" | ||||||
|
|
||||||
| [nogw_damp_pressure] | ||||||
| value = 85.0 | ||||||
| type = "float" | ||||||
| description = "Damping level pressure (Pa)" | ||||||
|
|
||||||
| [nogw_source_height] | ||||||
| value = 15000.0 | ||||||
| type = "float" | ||||||
| description = "Source level height (m)" | ||||||
|
|
||||||
| [nogw_Bw] | ||||||
| value = 0.4 | ||||||
| type = "float" | ||||||
| description = "Westward wave spectral amplitude (m^2/s^2)" | ||||||
|
|
||||||
| [nogw_Bn] | ||||||
| value = 0.0 | ||||||
| type = "float" | ||||||
| description = "Northward wave spectral amplitude (m^2/s^2)" | ||||||
|
|
||||||
| [nogw_dc] | ||||||
| value = 0.8 | ||||||
| type = "float" | ||||||
| description = "Phase speed resolution (m/s)" | ||||||
|
|
||||||
| [nogw_cmax] | ||||||
| value = 99.6 | ||||||
| type = "float" | ||||||
| description = "Maximum phase speed (m/s)" | ||||||
|
|
||||||
| [nogw_c0] | ||||||
| value = 0.0 | ||||||
| type = "float" | ||||||
| description = "Reference phase speed (m/s)" | ||||||
|
|
||||||
| [nogw_nk] | ||||||
| value = 1.0 | ||||||
| type = "float" | ||||||
| description = "Number of wave bands" | ||||||
|
|
||||||
| [nogw_cw] | ||||||
| value = 35.0 | ||||||
| type = "float" | ||||||
| description = "Westward phase speed half-width (m/s)" | ||||||
|
|
||||||
| [nogw_cw_tropics] | ||||||
| value = 35.0 | ||||||
| type = "float" | ||||||
| description = "Tropical westward phase speed half-width (m/s)" | ||||||
|
|
||||||
| [nogw_cn] | ||||||
| value = 2.0 | ||||||
| type = "float" | ||||||
| description = "Northward phase speed half-width (m/s)" | ||||||
|
|
||||||
| [nogw_Bt_0] | ||||||
| value = 0.0043 | ||||||
| type = "float" | ||||||
| description = "Base total source momentum flux (Pa)" | ||||||
|
|
||||||
| [nogw_Bt_n] | ||||||
| value = 0.0 | ||||||
| type = "float" | ||||||
| description = "Northern hemisphere total momentum flux amplitude (Pa)" | ||||||
|
|
||||||
| [nogw_Bt_s] | ||||||
| value = 0.0 | ||||||
| type = "float" | ||||||
| description = "Southern hemisphere total momentum flux amplitude (Pa)" | ||||||
|
|
||||||
| [nogw_Bt_eq] | ||||||
| value = 0.0043 | ||||||
| type = "float" | ||||||
| description = "Equatorial total momentum flux amplitude (Pa)" | ||||||
|
|
||||||
| [nogw_phi0_n] | ||||||
| value = 15.0 | ||||||
| type = "float" | ||||||
| description = "Northern hemisphere latitude center (degrees)" | ||||||
|
|
||||||
| [nogw_phi0_s] | ||||||
| value = -15.0 | ||||||
| type = "float" | ||||||
| description = "Southern hemisphere latitude center (degrees)" | ||||||
|
|
||||||
| [nogw_dphi_n] | ||||||
| value = 10.0 | ||||||
| type = "float" | ||||||
| description = "Northern hemisphere latitude width (degrees)" | ||||||
|
|
||||||
| [nogw_dphi_s] | ||||||
| value = -10.0 | ||||||
| type = "float" | ||||||
| description = "Southern hemisphere latitude width (degrees)" | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equation references aren't accompanied by a DOI paper link; could you please include that here as well ?