Skip to content

Conversation

@Rahul-2k4
Copy link

@Rahul-2k4 Rahul-2k4 commented Jan 3, 2026

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

Summary

  • Add regression test for WebVTT output format (-out=webvtt)
  • Create golden file sample1.webvtt for test validation
  • Add "Output Formats" category for format-specific tests
  • Document golden file provenance for reproducibility

Test plan

  • CI passes on all Python versions (3.10, 3.12, 3.13, 3.14)
  • WebVTT test correctly validates header-only output

Rahul-2k4 and others added 6 commits January 2, 2026 16:16
Add WebVTT output format test coverage to regression suite
- Add 'Output Formats' category for format-specific tests
- Fix misleading description to 'Validates WebVTT header generation on empty-caption input'
- Add explicit WEBVTT_TEST_ID constant to prevent fragile ordering bugs
- Update expected output to match exact line endings (CRLF)
- Add GOLDEN_FILE_PROVENANCE.md documenting reproducibility
The correct field in RegressionTestOutput should match the actual
sample1.webvtt file content (WEBVTT\r\n\r\n) for consistency.
@Rahul-2k4
Copy link
Author

Hi @canihavesomecoffee ,
Thanks for the clarification. I’ve moved the WebVTT category, regression test, and golden output registration into an Alembic migration so they’re applied to running instances via flask db upgrade, not just during install. The golden output is stored DB-side, and the category/test linkage is now explicit through regression_test_category, so existing deployments are covered.
Please let me know if you’d like me to also tighten or verify the fresh-install path.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants