Skip to content

Conversation

@ShivaGupta-14
Copy link
Contributor

@ShivaGupta-14 ShivaGupta-14 commented Dec 30, 2025

Description

  • Replace text input with Select dropdown for tag selection
  • Add "Create new tag" option in dropdown
  • Display selected tags as removable badges
  • Add uniqueTags, isCreatingNewTag, setIsCreatingNewTag props
  • Add data-testid to Priority, Tags, Recur SelectTriggers

Tests:

  • Update Select component mocks for testing
  • Rewrite tag tests to use dropdown selection
  • Add tests for dropdown selection and tag removal

Fixes: #210

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

Video

Screen.Recording.2025-12-30.at.10.52.35.PM.mov

Screenshots

Screenshot 2026-01-07 at 12 43 03 AM Screenshot 2026-01-07 at 12 43 08 AM

@github-actions
Copy link

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

Copy link
Contributor Author

@ShivaGupta-14 ShivaGupta-14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review done! ready for review

@ShivaGupta-14
Copy link
Contributor Author

Hi @its-me-abhishek!

I’ve added dropdown tests in AddTaskDialog.test.tsx since the logic is identical in both dialogs, for TaskDialog.test.tsx, I only kept the remove/save tests to avoid duplication, should I also add the same dropdown interaction tests there, or is covering it once sufficient? Let me know your preference.

Copy link
Collaborator

@its-me-abhishek its-me-abhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look into the above comments

@ShivaGupta-14
Copy link
Contributor Author

on it

@ShivaGupta-14 ShivaGupta-14 force-pushed the feat/210-tag-dropdown-selection branch from 06dcaa3 to d255e26 Compare January 6, 2026 19:06
@ShivaGupta-14
Copy link
Contributor Author

done with all changes, ready for review

Copy link
Collaborator

@its-me-abhishek its-me-abhishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some changes and fixes

@ShivaGupta-14
Copy link
Contributor Author

@its-me-abhishek, I understand your suggestions, but before proceeding, I’d genuinely like to get your input. I’ve also opened a PR for the same issue where I implemented a TagSelector component with search and multi-select functionality that shows the selected items. As a user, I personally prefer this approach, but I’d really appreciate your suggestion. I’m happy to proceed with whatever you decide.

…alogs

- Create AddMultiSelect component with search, select, and create functionality
- Display selected tags as removable chips with X buttons
- Add search filtering for existing tags
- Add inline "Create new tag" option for non-existing tags
- Integrate AddMultiSelect into TaskDialog and AddTaskDialog

Tests:
- Add comprehensive tests for AddMultiSelect component
- Update AddTaskDialog tests for new tag selection flow
- Update TaskDialog tests for tag editing with AddMultiSelect
- Mock AddMultiSelect in tests

Fixes: CCExtractor#210
@ShivaGupta-14 ShivaGupta-14 force-pushed the feat/210-tag-dropdown-selection branch from d255e26 to 20f9279 Compare January 11, 2026 17:26
@ShivaGupta-14
Copy link
Contributor Author

ShivaGupta-14 commented Jan 11, 2026

I implemented the current solution with considering all things in mind(your review and user experience), but i faced a issue with this ->

Issue faced:

the Popover inside Dialog had a click-through issue. radix UI's Dialog overlay blocks pointer events to Popover content because both use Portal and render at level with the same z-index.

Approaches explored:

  • z-index adjustments -> didn't work, the overlay intercepts events regardless of z-index

  • modal={false} on Dialog -> works, but breaks expected modal behavior (background scrolls, focus escapes)

  • modal={true} on Popover -> Clicks work, but input doesn't receive focus due to focus trap conflict

  • Working Solutions:

  • Option 1: Remove Portal (Simple)
    remove Primitive.Portal wrapper from popover.tsx, just (1 file change, 2 lines)
    Nothing else changes for this option. Just delete the opening and closing
    Risk: May clip if parent has overflow: hidden

  • Option 2: Container Solution (Current implementation)
    Pass container ref from Dialog to Popover (4 files changed, little bit complex to understand in first go)
    no clipping risk, portal behavior preserved

References:

stackover link: Link
GIthub issue: Link

Current Status

Implemented Container Solution. All tests passing.
Which approach do you prefer?

@ShivaGupta-14
Copy link
Contributor Author

ShivaGupta-14 commented Jan 11, 2026

also we can do one more thing if going with option 1st -> to maintain two popover file (one with portal and one without portal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reusable tags for Editing or Adding a task

2 participants