-
Notifications
You must be signed in to change notification settings - Fork 68
feat(tags): implement tags dropdown in Add/Edit Task dialogs #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(tags): implement tags dropdown in Add/Edit Task dialogs #351
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx
Show resolved
Hide resolved
ShivaGupta-14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self review done! ready for review
|
Hi @its-me-abhishek! I’ve added dropdown tests in AddTaskDialog.test.tsx since the logic is identical in both dialogs, for TaskDialog.test.tsx, I only kept the remove/save tests to avoid duplication, should I also add the same dropdown interaction tests there, or is covering it once sufficient? Let me know your preference. |
its-me-abhishek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look into the above comments
frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx
Show resolved
Hide resolved
frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx
Outdated
Show resolved
Hide resolved
|
on it |
06dcaa3 to
d255e26
Compare
|
done with all changes, ready for review |
frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/HomeComponents/Tasks/__tests__/AddTaskDialog.test.tsx
Show resolved
Hide resolved
frontend/src/components/HomeComponents/Tasks/__tests__/TaskDialog.test.tsx
Show resolved
Hide resolved
frontend/src/components/HomeComponents/Tasks/__tests__/tasks-utils.test.ts
Outdated
Show resolved
Hide resolved
its-me-abhishek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some changes and fixes
|
@its-me-abhishek, I understand your suggestions, but before proceeding, I’d genuinely like to get your input. I’ve also opened a PR for the same issue where I implemented a TagSelector component with search and multi-select functionality that shows the selected items. As a user, I personally prefer this approach, but I’d really appreciate your suggestion. I’m happy to proceed with whatever you decide. |
…alogs - Create AddMultiSelect component with search, select, and create functionality - Display selected tags as removable chips with X buttons - Add search filtering for existing tags - Add inline "Create new tag" option for non-existing tags - Integrate AddMultiSelect into TaskDialog and AddTaskDialog Tests: - Add comprehensive tests for AddMultiSelect component - Update AddTaskDialog tests for new tag selection flow - Update TaskDialog tests for tag editing with AddMultiSelect - Mock AddMultiSelect in tests Fixes: CCExtractor#210
d255e26 to
20f9279
Compare
|
I implemented the current solution with considering all things in mind(your review and user experience), but i faced a issue with this -> Issue faced:the Popover inside Dialog had a click-through issue. radix UI's Dialog overlay blocks pointer events to Popover content because both use Portal and render at level with the same z-index. Approaches explored:
References:stackover link: Link Current StatusImplemented Container Solution. All tests passing. |
|
also we can do one more thing if going with option 1st -> to maintain two popover file (one with portal and one without portal) |
Description
Tests:
Fixes: #210
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
Video
Screen.Recording.2025-12-30.at.10.52.35.PM.mov
Screenshots