fmt: simplfy and reduce size of integer formatting #458
+107
−209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more completely unifies unsigned and signed integer
formatting. It also removes an unused option (to force the
printing of the sign) and an unused field.
Interestingly, these changes result in quite a substantial
(relatively speaking) decrease in LLVM lines. In my Biff
benchmark, prior to this PR, we were getting 753,181 LLVM
lines. But with this PR, we get 745,928 LLVM lines.
For compile times on my Biff benchmark (which is just doing
a
cargo buildand acargo build --releaseafter acargo cleanfor each), it seems like there's basicallyno change. With maybe the release build being a hair faster.
Before this PR:
After this PR: