binary-size: remove many uses of write!
#457
Merged
+79
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `write!` unnecessarily when a simple `f.write_str` would do ends up generating more LLVM lines on my Biff `cargo llvm-lines` benchmark. This PR replaces those uses of `write!` with `Formatter::write_str`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
write!unnecessarily when a simplef.write_strwould do endsup generating more LLVM lines on my Biff
cargo llvm-linesbenchmark.This PR replaces those uses of
write!withFormatter::write_str.This is only a modest improvement. It only results in trimming a few hundred
LLVM lines on my Biff benchmark. But there's really no reason not to do this,
so this is just a free, albeit small, win.