error: add predicates for basic error introspection #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously only used this in the `core::fmt::Display` trait implementation, so we just inlined it there. But we'll want to use it to get the root of the chain for error predicates, so this commit does some refactoring to provide a standalone internal iterator for the error chain.
I'm somewhat concerned that this doesn't cover all cases, but I think this should be a good start.
BurntSushi
force-pushed
the
ag/error-predicates
branch
from
d0bf15f to
70c50fd
Compare
There's only a few of these, but they seem like a distinct category from other error types. It's also nice to do this and standarize on the specific error message. The other reason I wanted to do this was to distinguish it from a possible "is configuration error" category. (e.g., Trying to round a span to the nearest year without a relative datatime.) These could also be seen as configuration errors, but I want them to be in a separate category I think.
BurntSushi
force-pushed
the
ag/error-predicates
branch
from
70c50fd to
9b76888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three predicates to
jiff::Error:is_rangereturns true when the error was caused by a value goingout of Jiff's supported range.
is_crate_featurereturns true when the error was caused by a Jiffcrate feature not being enabled.
is_invalid_parameterreturns true when the error was caused by somekind of illegal configuration in a function call. e.g., Trying to round
the span between two
Timestampvalues to the nearest year.There is probably more introspection that we could do, but I think this
should cover the more immediate need.
Closes #418