-
-
Notifications
You must be signed in to change notification settings - Fork 18
BL-15806 Remove-Copy-Hyperlink-command #7639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Version6.3
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
|
| Filename | Overview |
|---|---|
| src/BloomExe/Edit/EditingModel.cs | Removed CopyHyperlink method and CanCopyHyperlink property; IsOutsideFrontCover property now unused |
| src/BloomExe/Edit/PageListView.cs | Removed Copy Hyperlink menu item and associated state tracking variable |
| DistFiles/localization/en/Bloom.xlf | Marked two hyperlink-related localization strings as obsolete for Bloom 6.3 |
Sequence Diagram
sequenceDiagram
participant User
participant PageListView
participant EditingModel
participant PortableClipboard
Note over PageListView,EditingModel: Before (Copy Hyperlink Feature)
User->>PageListView: Right-click on page
PageListView->>EditingModel: Check CanCopyHyperlink
EditingModel-->>PageListView: Return true/false
PageListView->>User: Show "Copy Hyperlink" menu item
User->>PageListView: Click "Copy Hyperlink"
PageListView->>EditingModel: CopyHyperlink(page)
EditingModel->>EditingModel: Get page ID or "cover"
EditingModel->>PortableClipboard: SetText(hyperlink)
EditingModel-->>PageListView: Return
PageListView->>User: Show dialog explaining hyperlink usage
Note over PageListView,EditingModel: After (Feature Removed)
User->>PageListView: Right-click on page
PageListView->>User: Show menu without "Copy Hyperlink" option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
StephenMcConnel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StephenMcConnel reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nabalone).
StephenMcConnel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StephenMcConnel made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nabalone).
src/BloomExe/Edit/EditingModel.cs line 709 at r1 (raw file):
// to cease to exist altogether. // The only exception is the front cover page, which uses a magic value instead of the page id. public bool CanCopyHyperlink => CanCopyPage || IsOutsideFrontCover;
Devin flagged that IsOutsideFrontCover is no longer used after this change.
64cc68b to
252c73f
Compare
This change is