Skip to content

Conversation

@nabalone
Copy link
Contributor

@nabalone nabalone commented Jan 29, 2026


Open with Devin

This change is Reviewable

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional flag.

Open in Devin Review

@greptile-apps
Copy link

greptile-apps bot commented Jan 29, 2026

Greptile Overview

Greptile Summary

This PR removes the "Copy Hyperlink" command from the page context menu in the Edit tab. The feature allowed users to copy a hyperlink to a page for use in table of contents, but has been deprecated in Bloom 6.3.

Changes made:

  • Removed CopyHyperlink() method and CanCopyHyperlink property from EditingModel.cs:701-708 and EditingModel.cs:1933-1943
  • Removed "Copy Hyperlink" menu item from page context menu in PageListView.cs:78-107
  • Removed _hyperlinkMessageShown state tracking variable from PageListView.cs:21
  • Marked localization strings EditTab.HowToUseHyperlink and EditTab.UsingHyperlink as obsolete in Bloom.xlf

Minor cleanup opportunity:

  • The IsOutsideFrontCover property at EditingModel.cs:699-702 is now unused and could be removed in a follow-up

Important Files Changed

Filename Overview
src/BloomExe/Edit/EditingModel.cs Removed CopyHyperlink method and CanCopyHyperlink property; IsOutsideFrontCover property now unused
src/BloomExe/Edit/PageListView.cs Removed Copy Hyperlink menu item and associated state tracking variable
DistFiles/localization/en/Bloom.xlf Marked two hyperlink-related localization strings as obsolete for Bloom 6.3

Sequence Diagram

sequenceDiagram
    participant User
    participant PageListView
    participant EditingModel
    participant PortableClipboard

    Note over PageListView,EditingModel: Before (Copy Hyperlink Feature)
    User->>PageListView: Right-click on page
    PageListView->>EditingModel: Check CanCopyHyperlink
    EditingModel-->>PageListView: Return true/false
    PageListView->>User: Show "Copy Hyperlink" menu item
    User->>PageListView: Click "Copy Hyperlink"
    PageListView->>EditingModel: CopyHyperlink(page)
    EditingModel->>EditingModel: Get page ID or "cover"
    EditingModel->>PortableClipboard: SetText(hyperlink)
    EditingModel-->>PageListView: Return
    PageListView->>User: Show dialog explaining hyperlink usage

    Note over PageListView,EditingModel: After (Feature Removed)
    User->>PageListView: Right-click on page
    PageListView->>User: Show menu without "Copy Hyperlink" option
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@StephenMcConnel StephenMcConnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephenMcConnel reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nabalone).

Copy link
Contributor

@StephenMcConnel StephenMcConnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StephenMcConnel made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nabalone).


src/BloomExe/Edit/EditingModel.cs line 709 at r1 (raw file):

        // to cease to exist altogether.
        // The only exception is the front cover page, which uses a magic value instead of the page id.
        public bool CanCopyHyperlink => CanCopyPage || IsOutsideFrontCover;

Devin flagged that IsOutsideFrontCover is no longer used after this change.

@nabalone nabalone force-pushed the BL-15806_Remove-Copy-Hyperlink-command branch from 64cc68b to 252c73f Compare January 30, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants