-
Notifications
You must be signed in to change notification settings - Fork 66
fix: playwright tests after render-engine migration #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@danielcristho - The actions are still failing. I'm not sure if you have the ability to commit changes to the actions but can you try to as well as make sure precommit is passing. |
|
Ah, I missed updating the actions. I’ll fix it ASAP and make sure the pre-commit is passing. |
|
@kjaymiller - I've passed the actions and pre-commit. I'm also updating the year in the footer. I've got several failed tests. I think the failure is coming from content/template (missing lang attribute, title format inconsistencies etc).
|
kjaymiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned that the tests were failing can you try running the tests with more verbose logging to troubleshoot the issues. I don't want to approve the PR without a clear understanding of what the remaining issues are.
|
I reran the test suite with verbose logging to investigate the failures. Most of the failures are test-related issues introduced during the migration from Jekyll to Render Engine . Test fixed:
Remaining issues:
Let me know how you'd like to proceed on the remaining items. |
|
I've added issues for the remaining problems. |

Issue Link 🔗: #750
Issue: #750
Type of Change
Description 📋
What: Provide an overview of the issue this PR addresses. Explain the context and background information.
Why: Describe why the changes are being made. Highlight key updates, new features, or bug fixes.
How: Explain how these changes will affect the project or end-users.
Checklist ✅
pre-commit run --allAdditional Notes & Screenshots
Before: Playwright tests were failing with server startup timeouts and accessibility violations were blocking deployment.
After: All tests pass reliably, accessibility compliance achieved, and deployment works correctly with render-engine.
Add any additional notes or comments that might be helpful for the reviewers.