add 'sync' command to sync remote split assignments with local schema #64
Conversation
SirNeuman
changed the title
SirNeuman
changed the title
| splitMap["weights"] = valueMap["weights"] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Basically we unmarshal both remote JSON and local YAML files. Then we match split names, and whatever split names match we assign the "weights" from the JSON to the YAML file. Then we write and marshal the YAML object back.
There was a problem hiding this comment.
Is there anything that can be reused from (or incorporated into) the existing schema.go module?
There was a problem hiding this comment.
Yeah i'm kinda learning this project and go as i go... i've refactored it to use schema write and read methods. Now i'm looking into whether i can use the "server" get method so we don't have to pass in the remote url as an argument, and also hopefully figure out how to clean some of this stuff around unmarshalling/marshalling the weights from json and casting them to serializable yaml values to write back to the file
There was a problem hiding this comment.
@smudge i think it's at a good place now for another review
smudge
left a comment
smudge
left a comment
There was a problem hiding this comment.
domain LGTM && platform LGTM -- 👏 I love this -- great utility function that resolves a longstanding painpoint w.r.t. local dev getting out of sync with what is actually true in production today.
2 participants
Context:
Sometimes we want to sync our local TestTrack assignments with the weights in the production environment. Creating a TestTrack CLI command to easily take all the assignments from remote json split registry and assign them to local yaml assignment file.