-
Notifications
You must be signed in to change notification settings - Fork 268
[pre-commit.ci] pre-commit autoupdate #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5481bce to
1d9f59a
Compare
1d9f59a to
2b65538
Compare
2b65538 to
b2baba0
Compare
c5822a3 to
4eca05b
Compare
|
Due to update of mypy, some checks are now failing. In my testing, mypy fails on a lot of files in Beanie codebase, as it's simply not "up to its standards". |
4eca05b to
8ee6504
Compare
|
@adeelsohailahmed, regarding this PR and the failing pre-commit check, mypy.....................................................................Failed
- hook id: mypy
- exit code: 1
beanie/odm/utils/find.py:385: error: Incompatible types in assignment (expression has type "Any | None", variable has type "dict[str, Any]") [assignment]I have opened #1191 which should among other things also fix this failure: beanie/beanie/odm/utils/find.py Line 361 in 3f70a27
It would be great if we could have that huge PR merged, could you please take a look when you have the time? |
8cfd4d6 to
28db7d3
Compare
28db7d3 to
5e435df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I made a mistake here!
|
Really @Riverfount? We have CI tests failing, and if we check for this locally, it would also fail locally when trying to commit... |
5e435df to
48ff0ed
Compare
de300c3 to
2bed2b4
Compare
2bed2b4 to
c60e1f6
Compare
c60e1f6 to
310d9ae
Compare
f19df67 to
7f412a4
Compare
7f412a4 to
abef987
Compare
899f55b to
a7bfaad
Compare
Riverfount
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @Riverfount, pre-commit.ci check is still failing due to mypy issues. They should be fixed first before merging this. |
3dc5150 to
871f43e
Compare
81cfe06 to
d0b1f5c
Compare
bb97c6b to
fbb13db
Compare
fbb13db to
a5777a9
Compare
f429c51 to
119f9ba
Compare
119f9ba to
893b0d5
Compare
893b0d5 to
520380c
Compare
updates: - https://github.com/charliermarsh/ruff-pre-commit → https://github.com/astral-sh/ruff-pre-commit - [github.com/astral-sh/ruff-pre-commit: v0.11.6 → v0.14.8](astral-sh/ruff-pre-commit@v0.11.6...v0.14.8) - [github.com/pre-commit/mirrors-mypy: v1.15.0 → v1.19.0](pre-commit/mirrors-mypy@v1.15.0...v1.19.0)
520380c to
dab9516
Compare
updates: