use UV as dependency management tool #1149
Conversation
07pepa
requested review from
a team,
CAPITAINMARVEL,
LawMixer,
Riverfount and
adeelsohailahmed
staticxterm
left a comment
staticxterm
left a comment
There was a problem hiding this comment.
Honestly, it looks very very good, I like it.
Needs some minor tweaks to fix the Python version used in the CI tests and some other comments.
staticxterm
left a comment
staticxterm
left a comment
There was a problem hiding this comment.
Like I mentioned previously, I like this.
But, I can't yet approve it as there are still some comments left unanswered and the development experience needs to be improved (namely that doing uv sync.. installs all needed development and test dependencies - that everything just works out of the box).
pyproject.toml
Outdated
| description = "Asynchronous Python ODM for MongoDB" | ||
| readme = "README.md" | ||
| requires-python = ">=3.8,<4.0" | ||
| requires-python = ">=3.9,<4.0" |
There was a problem hiding this comment.
I now understand why you bump the minimum supported Python version to 3.9 due to pydantic_settings also supporting the Python 3.9 and onwards.
I don't know, I guess we can drop the support then but we need to reach consensus on this (and at some later point when to remove Pydantic v1 support as well).
|
This PR is stale because it has been open 45 days with no activity. |
|
This PR is stale because it has been open 45 days with no activity. |
staticxterm
force-pushed
the
use-uv
branch
2 times, most recently
from
d655f2e to
3997f02
Compare
3 participants
Introduce
uvas the dependency management tool.Modified pyproject.toml, GitHub actions and documentation.
Disabled "Publish docs" action as it was always failing due to missing credentials.