-
Notifications
You must be signed in to change notification settings - Fork 3
Sync UserAdminModule docs with source functions #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync UserAdminModule docs with source functions #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR synchronizes UserAdminModule documentation by updating fenced code blocks from PowerShell source files. The changes include only automated sentinel-wrapped code updates without any file renames or front matter modifications.
- Automated sync of PowerShell function code blocks from source files
- Addition of sentinel comments for code boundary management
- Addition of PowerShell edition requirements for compatibility
- Removal of example usage comments and code snippets
Reviewed Changes
Copilot reviewed 300 out of 556 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Get-WeekDayInMonth.md | Added function code sentinels and PSEdition Desktop requirement |
| Get-Weather.md | Added function code sentinels |
| Get-WTFismyIP.md | Added function code sentinels and PSEdition Desktop requirement |
| Get-WMIHardwareOSInfo.md | Added function code sentinels |
| Get-W32TimeStripchartResults.md | Added function code sentinels and PSEdition Desktop requirement |
| Get-W32TimeSource.md | Added function code sentinels and PSEdition Desktop requirement |
| Get-W32TimeServiceStatus.md | Added function code sentinels and PSEdition Desktop requirement |
| Get-W32TimeConfiguration.md | Added function code sentinels and PSEdition Desktop requirement |
| Get-VpnFailoverEventLogs.md | Added function code sentinels, PSEdition requirement, and removed example usage |
| Get-VMInformation.md | Added function code sentinels and significantly updated function implementation |
| ... (and many more files following the same pattern) |
| ```powershell | ||
| <# | ||
| #requires -PSEdition Desktop | ||
| function Get-ChuckNorrisJoke { |
Copilot
AI
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function implementation has been completely replaced with a different function. The old function was for finding recently saved files, but the new function retrieves Chuck Norris jokes from an API. This appears to be incorrect content for this documentation file.
| Write-Error "Error retrieving data: $_" | ||
| } | ||
| } | ||
| } |
Copilot
AI
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several class definitions (Event, EnglandAndWales, Scotland, NorthernIreland, BankHolidays) that were removed are likely required for the function to work properly, as these classes appear to define the structure of the returned data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
scripts-blog/_posts/UserAdminModule/Convert-AzuretoOnPrem.md
Lines 118 to 122 in 6df20ad
| if ($PSCmdlet.ShouldProcess("$User", "Convertion of Azure AD user to on-premises AD user")) { | |
| $adUser = ConvertTo-ADUser -AzureADUser $user -AccountPassword $AccountPassword | |
| New-OnPremADUser -ADUser $adUser | |
| Export-ADUser -ADUser $adUser | |
| Set-AzureADUserImmutableId -AzureADUser $user -ADUser $adUser |
The script block now only publishes Convert-AzuretoOnPrem, but the body still calls ConvertTo-ADUser, New-OnPremADUser, Export-ADUser, and Set-AzureADUserImmutableId. In the prior version these helper functions were defined in the same code block, so copying the snippet from the docs produced a working script. After this commit those definitions were removed, so anyone running the script as published will hit “command not found” errors for each helper. Unless those functions are guaranteed to be imported from elsewhere, they need to be restored or the calls removed.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Automated sync of fenced code blocks from .ps1 sources.
Includes only sentinel-wrapped code updates; no file renames or front matter changes.
https://chatgpt.com/codex/tasks/task_e_68dd004eee9c832d82bcc0d8d6377189