Skip to content

fix: remove iconv conversion #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shyim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove iconv conversion #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/Encoder/Encoder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ private static function appendBytes(string $content, Mode $mode, BitArray $bits,
break;

case Mode::BYTE():
self::append8BitBytes($content, $bits, $encoding);
self::append8BitBytes($content, $bits);
break;

case Mode::KANJI():
Expand Down Expand Up @@ -608,17 +608,9 @@ private static function appendAlphanumericBytes(string $content, BitArray $bits)

/**
* Appends regular 8-bit bytes to a bit array.
*
* @throws WriterException if content cannot be encoded to target encoding
*/
private static function append8BitBytes(string $content, BitArray $bits, string $encoding) : void
private static function append8BitBytes(string $bytes, BitArray $bits) : void
{
$bytes = @iconv('utf-8', $encoding, $content);
Copy link
Contributor

@williamdes williamdes Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be done only if mbstring is not present ?


if (false === $bytes) {
throw new WriterException('Could not encode content to ' . $encoding);
}

$length = strlen($bytes);

for ($i = 0; $i < $length; $i++) {
Expand Down