-
Notifications
You must be signed in to change notification settings - Fork 68
New NPM #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New NPM #665
Conversation
Prevent partial outputs when unzipping Babylon Native sources on macOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes multiple React Native 0.64, 0.65, and 0.69 package test applications as part of consolidating the Babylon React Native package structure. The change removes old test infrastructure and scaffolding applications that were used to validate different React Native versions, streamlining the repository to support a single unified package.
- Removes entire PackageTest apps for React Native versions 0.64, 0.65, and 0.69
- Eliminates platform-specific test scaffolding for Android, iOS, and Windows
- Clears out version-specific configuration files, build scripts, and native code
Reviewed changes
Copilot reviewed 227 out of 961 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Apps/PackageTest/0.69.0/* | Removed complete RN 0.69 test app including Android/iOS configs and native architecture code |
| Apps/PackageTest/0.65.0/* | Removed complete RN 0.65 test app with all platform-specific files and build configurations |
| Apps/PackageTest/0.64.0/* | Removed complete RN 0.64 test app including Windows-specific project files and native modules |
Files not reviewed (3)
- Apps/PackageTest/0.63.1/ios/PackageTest.xcworkspace/contents.xcworkspacedata: Language not supported
- Apps/PackageTest/0.64.0/ios/PackageTest.xcworkspace/contents.xcworkspacedata: Language not supported
- Apps/PackageTest/0.65.0/ios/PackageTest.xcworkspace/contents.xcworkspacedata: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bghgary
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick scan. Looks good to me, but @ryantrem probably should approve before you merge.
|
|
||
| Use the react native template to generate the app: | ||
| It's still getting fully wired up as a replacement, so if you are seeing this message it means that it's not in its final form yet! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this still be here?
WIP
Goal
Deliver 1 single self contained package with sources (no fetch, no secondary download) for all platform, for all RN versions.
Deprecated existing (Playground, tests, build script) in favor of a single RNTA Playground and simpler tooling.
Building the new NPM
Testing
PR Changes
react-native-iosandroidandreact-native-windowscontent intoModules/@babylonjs/react-nativefolderbuildBabylonNativeSourceTreegulp export to gather BN sourcesTODO
BABYLON_NATIVE_PLUGIN_NATIVECAMERA=0,BABYLON_NATIVE_PLUGIN_NATIVEXR=0)- [ ] Script to change RN version for RNTALeft to users to get a working node environmentissue with RN 0.78. fixed with RN 0.80. not tested with previous versions. To fix (if it happens) on user side.
Notes:
Pros/Cons of sources in package
Pros
BASE_KITpackage)Cons
Sizes
Binary packages
TS : 23Kb
Windows: 102Mb (700Mb Unzipped)
iOS-Android: 21Mb (65Mb Unzipped)
Source package
13Mb (74Mb Unzipped)