Skip to content

Conversation

@adhamrait
Copy link
Contributor

Add components to change the uncertainty in alpha and beta in the gui:
image

@adhamrait adhamrait requested review from EZoni and RemiLehe December 11, 2025 23:02
@adhamrait
Copy link
Contributor Author

image Added the two separate variables and a toggle to display one or the other (currently gives an error if trying to display the inferred calibration values)

Comment on lines 108 to 110
with html.Div(
style="display: flex; align-items: center; margin: 20px; justify-content: space-between;"
):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me/us again on why we wrap everything within a with html.Div():? What does this accomplish specifically? Just trying to understand if it's necessary, optional, if it should be used elsewhere/everywhere where we set up other graphical components, etc. I'm sure I haven't used it consistently, or at all, so far, so I want to make sure I understand why it's here and what it does.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also search the answer online, I'm asking just in case you have the answer ready off the top of your head.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrapped this in a div so that the alpha and beta sections are separate and they're flexboxes, but looking at it now I can just use a VRow to be more consistent with other parts of the code

@EZoni EZoni added ml Tasks associated with training ML models dashboard Tasks associated with the Trame dashboard labels Dec 18, 2025
@EZoni EZoni self-requested a review December 19, 2025 00:29
@EZoni EZoni changed the title Add uncertainty components to the gui [WIP] Add uncertainty components to the gui Dec 19, 2025
@EZoni
Copy link
Member

EZoni commented Dec 19, 2025

I flagged the PR as "[WIP]" because there may be some style issues to fix. For example, I see this on my browser:

Screenshot from 2025-12-19 10-06-49

In general I think we should find a way to expand those panels, because there's a lot of unused empty space horizontally, overall on the whole page.

@EZoni
Copy link
Member

EZoni commented Dec 19, 2025

The issue mentioned in #342 (comment) is fixed in #351.

@EZoni
Copy link
Member

EZoni commented Dec 19, 2025

FYI, final look after the latest commits (slightly different than the one in the PR description):

Screenshot from 2025-12-19 11-54-53

@EZoni EZoni changed the title [WIP] Add uncertainty components to the gui Add guess, inferred components for calibration constants Dec 19, 2025
@EZoni EZoni self-assigned this Dec 19, 2025
@EZoni EZoni merged commit a1cf3f1 into main Dec 19, 2025
3 checks passed
@EZoni EZoni deleted the adhamrait/configuration_uncertainty_gui branch December 19, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Tasks associated with the Trame dashboard ml Tasks associated with training ML models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants