fix: SignOut callback URL breaks with custom dotnet areas #1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were having an issue with the signout function, upon looking into the code, it seems that the hardcoded callback URL is setup off of root /Account/SignedOut omitting the area /MicrosoftIdentity/. This caused our app to append the /SignOut off of the last route config action setup... As we renamed/commented them out the action would just append off of the next final action. Our instincts would be to declare the full area/controller/action here as: /MicrosoftIdentity/Account/SignedOut into the Callback path here, however, we did see other coding consistancy utilizing the ~ home root. Unsure of which to do (nor are we sure ~ will work here) we went with keeping coding consistant (as it looked like it could have been possible to have this be a simple type-o omission). Leaving out the declared area is grabbing the current area and sending the request to somewhere that simply doesn't exist. Please feel free to update as we are pretty new to all of this and are unaware of understanding how to actually test this fix locally before sending a PR. And please feel free to send an email/message with any questions. Thank you, have a great day, --PJ
Collaborator
|
Thanks @pj-evans |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having an issue with the signout function, upon looking into the code, it seems that the hardcoded callback URL is setup off of root /Account/SignedOut omitting the area /MicrosoftIdentity/.
This caused our app to append the /SignOut off of the last route config action setup... As we renamed/commented them out the action would just append off of the next final action.
Our instincts would be to declare the full area/controller/action here as: /MicrosoftIdentity/Account/SignedOut into the Callback path here, however, we did see other coding consistancy utilizing the ~ home root. Unsure of which to do (nor are we sure ~ will work here) we went with keeping coding consistant (as it looked like it could have been possible to have this be a simple type-o omission).
Leaving out the declared area is grabbing the current area and sending the request to somewhere that simply doesn't exist.
Please feel free to update as we are pretty new to all of this and are unaware of understanding how to actually test this fix locally before sending a PR. And please feel free to send an email/message with any questions.
Thank you, have a great day,
--PJ