Skip to content

Conversation

@vittoriasalim
Copy link
Contributor

as title

@vittoriasalim vittoriasalim marked this pull request as ready for review December 6, 2025 01:31
Copilot AI review requested due to automatic review settings December 6, 2025 01:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR decouples Azure Firewall functionality into a separate Terraform module, enabling better modularity and allowing route tables to reference firewalls dynamically. The changes introduce a new firewall module with comprehensive support for NAT, network, and application rule collections, and update the route table module to support firewall and public IP address references.

  • Introduces a new dedicated firewall module with support for rule collections (NAT, network, and application rules)
  • Updates route table configuration to support dynamic references to firewall private IPs and public IP addresses
  • Adds new output to public-ip module for IP address mapping

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
modules/terraform/azure/variables.tf Added new firewall_config_list variable and updated route_table_config_list with optional fields for firewall/public IP references
modules/terraform/azure/main.tf Added firewall module instantiation and updated route_table module to receive firewall/public IP mappings with proper dependencies
modules/terraform/azure/route-table/variables.tf Added firewall_private_ips and public_ip_addresses map variables for dynamic IP resolution
modules/terraform/azure/route-table/main.tf Updated route resource to support dynamic address prefix and next hop IP address resolution from firewall/public IP names
modules/terraform/azure/public-ip/output.tf Added pip_addresses output to expose public IP address mapping
modules/terraform/azure/firewall/variables.tf Defined firewall module input variables with comprehensive firewall configuration options
modules/terraform/azure/firewall/main.tf Implemented firewall resource creation with NAT, network, and application rule collections
modules/terraform/azure/firewall/output.tf Added output for firewall private IP addresses mapping
modules/terraform/azure/firewall/README.md Added module documentation with usage examples and input/output tables

@vittoriasalim vittoriasalim force-pushed the vitto/decouple_firewall branch from 068f012 to 3078026 Compare December 18, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants