Skip to content

Conversation

@JasonXuDeveloper
Copy link
Contributor

Fixes #224

Changes

This PR fixes a typo where the field name seletor should be selector across the codebase.

Affected Files

  • api/types/load_traffic.go - Fixed JSON/YAML struct tags
  • api/types/load_traffic_test.go - Updated test YAML examples (3 occurrences)
  • docs/runkperf.md - Updated documentation JSON examples (3 occurrences)
  • contrib/internal/manifests/loadprofile/node100_pod10k.yaml - Updated load profile manifest

Testing

  • All existing tests pass
  • Build succeeds without errors
  • YAML/JSON deserialization works correctly with the corrected field name

Fixes Azure#224

- Fix JSON/YAML struct tags in api/types/load_traffic.go
- Update test YAML examples in api/types/load_traffic_test.go
- Update documentation examples in docs/runkperf.md
- Update load profile manifest in contrib/internal/manifests/loadprofile/node100_pod10k.yaml
Copy link
Contributor

@xinWeiWei24 xinWeiWei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinWeiWei24 xinWeiWei24 merged commit f3f2d5a into Azure:main Dec 15, 2025
4 checks passed
@JasonXuDeveloper JasonXuDeveloper deleted the fix-selector-typo-upstream branch December 16, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo: Selector field is currently named as seletor

2 participants