Work to fix 114 #118
Draft
Work to fix 114 #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is work to fix #114. It was done with a big assist from AI, so I'm adding it as a draft for review.
The goal is to apply a filter that, if no user roles are returned, can inspect the user object and assign a set of roles. The returned values are validated as actual roles, and the filter runs only when a user has no roles.
This filter would allow someone to circumvent intended governance choices, for example, if a customer wanted a user with no roles to get the default user. I suggest this is an acceptable risk, but others may disagree.
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run build.