-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(bedrock): support more models #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bedrock): support more models #420
Conversation
Some models such as Claude Haiku 4.5 do not support setting both temperature and top_p at the same time.
Summary of ChangesHello @Warashi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the flexibility and compatibility of the Bedrock client by enabling support for a wider range of model inference profiles, including those used for cross-region operations. Concurrently, it refines how model configuration parameters are handled, making Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces two main changes: it updates the logic for parsing Bedrock model IDs to support cross-region inference profiles, and it makes temperature and top_p optional parameters for Bedrock models. The changes are well-aligned with the goals described.
My review includes a couple of suggestions:
- In
api/bedrock_client.py, I've proposed a more robust implementation for extracting the model provider to handle edge cases like empty segments in the model ID, which could currently lead to bugs. - In
api/websocket_wiki.py, I've suggested a small refactoring to make the code for adding optional parameters more concise and maintainable.
Overall, these are good improvements. Addressing the feedback will make the code more robust and maintainable.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces two key improvements for AWS Bedrock integration. First, it enhances model ID parsing to support cross-region inference profiles, making the client more flexible. Second, it makes the temperature and top_p parameters optional, which is necessary for certain models that do not accept both simultaneously. The changes are well-implemented and address the stated goals. I have one suggestion to improve the readability of the model provider extraction logic.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
I want to use cross region inference profile such as
global.anthropic.claude-sonnet-4-5-20250929-v1:0orglobal.cohere.embed-v4:0.Current implementation assumes the first segment to be provider name, but cross region inference profile id has the region name at the first segment.
This change makes us be able to use cross region inference profile.
Additionaly, this PR makes
temparatureandtop_pas optional arguments, becasue some model such as Claude Haiku 4.5 does not support set both of them at the same time.