Skip to content

Conversation

@isaachilly
Copy link
Collaborator

@isaachilly isaachilly commented Nov 25, 2025

Integrated the filtersPanelPopover component into the environment overview UI.

Added a test to verify that the filtering panel can be successfully opened.

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Filters panel able to be opened but no filters in it as of yet.

Notable changes for developers:

  • N/A

Changes made to the database:

  • N/A

Integrated the filtersPanelPopover component into the environment overview UI.

Added a test to verify that the filtering panel can be successfully opened.
@isaachilly isaachilly self-assigned this Nov 25, 2025
@isaachilly isaachilly requested a review from graduta as a code owner November 25, 2025 09:20
@isaachilly isaachilly added frontend javascript Pull requests that update Javascript code labels Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.47%. Comparing base (7368f5e) to head (f84191f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../Environments/Overview/EnvironmentOverviewModel.js 0.00% 24 Missing ⚠️
lib/public/views/Environments/EnvironmentModel.js 0.00% 2 Missing ⚠️
...ironments/Overview/environmentOverviewComponent.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
- Coverage   45.52%   45.47%   -0.05%     
==========================================
  Files        1023     1023              
  Lines       17028    17050      +22     
  Branches     3087     3092       +5     
==========================================
+ Hits         7752     7754       +2     
- Misses       9276     9296      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Adds FilteringModel to EnvironmentOverviewModel, enabling filter state management.
Misuse of getLoadParameters() method to apply filters to api query. Refactored to use correct, getRootEndpoint(), method now and apply them there.
Missed adding import for buildUrl.
@graduta graduta merged commit 3c0d360 into main Nov 25, 2025
21 of 24 checks passed
@graduta graduta deleted the feature/O2B-1489/Add-filtering-panel-to-environments-page branch November 25, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

3 participants