Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Nov 3, 2025

PR was created automatically by the release workflow, hope you release it as soon as possible!


Note

Refines ambient occlusion to ignore empty bounding boxes, revamps flying detection via physics engine with periodic sync, and bumps flying-squid to 0.0.118.

  • Rendering/Mesher:
    • Adjust AO: models.ts uses model.ao ?? block.boundingBox !== 'empty' and world.ts shouldMakeAo checks block.boundingBox !== 'empty'.
  • Controls:
    • Update flying detection to (bot as any).physicsEngineCtx?.state?.flying with physicsTick sync to gameAdditionalState.isFlying; remove immediate state assignment in toggleFly.
  • Dependencies:

Written by Cursor Bugbot for commit 2da6ef5. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.


Comment @coderabbitai help to get the list of available commands and usage tips.

cursor[bot]

This comment was marked as outdated.

})
}

customEvents.on('gameLoaded', physicsFlyingCheck)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Leaky Event Listeners on Game Load Repeats

Memory leak: The physicsFlyingCheck function registers a new 'physicsTick' event listener on the bot every time 'gameLoaded' is triggered, but never removes previous listeners. This will accumulate multiple identical event handlers if the game is loaded multiple times (e.g., disconnecting and reconnecting), causing the same callback to run multiple times per physics tick and wasting resources.

Fix in Cursor Fix in Web

@zardoy zardoy merged commit e7c2834 into release Nov 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants