dont always request pointer lock #443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to_follow auto follow players
…am_changes Merge upstream changes from zardoy with current next branch
game audio & music
silently ignore missing files (404)
remove notification for audio warning, let it fallback silently
KRA-691 - iframe audio issues
…anges add spectator mode overlay and mouse capture messages
…ead of going straight to spectator mode
…anges Fix followed player death issue
…anges build fix
…anges fix spectator mode bug
…anges hide chat in client
remove mineflayer-auto-jump and mineflayer-physics-util
|
@kennethkoontz is attempting to deploy a commit to the Vitaly Turovksy's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Caution Review failedThe pull request is closed. WalkthroughThis PR performs a major architectural refactor, transitioning from a monolithic Viewer class to a modular AppViewer/GraphicsBackend abstraction with Three.js rendering, adds single-file build support, replay packet handling, iframe communication, and multiple game features (follow camera, sound system, progress reporting). Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application<br/>(index.ts)
participant AV as AppViewer
participant Backend as GraphicsBackend
participant Renderer as DocumentRenderer /<br/>WorldRendererThree
participant World as WorldDataEmitter
App->>AV: loadBackend()
AV->>Backend: createGraphicsBackend(initOptions)
Backend->>Renderer: new DocumentRenderer()
Backend-->>AV: backend ready
App->>AV: startWorld(displayOptions)
AV->>Backend: startWorld(displayOptions)
Backend->>Renderer: instantiate WorldRendererThree
Renderer->>World: connect(worldView)
World-->>Renderer: emit chunk/block updates
Renderer->>App: render loop via beforeRenderFrame
App->>Backend: updateCamera(pos, yaw, pitch)
Backend->>Renderer: forward camera updates
Renderer->>Renderer: update projection & render
App->>AV: disconnect()
AV->>Backend: disconnect()
Backend->>Renderer: dispose()
Renderer-->>App: cleanup complete
sequenceDiagram
participant User
participant UI as UI Layer
participant PR as ProgressReporter
participant App as AppViewer
participant Backend as GraphicsBackend
User->>UI: Download Resource Pack
UI->>PR: createFullScreenProgressReporter()
PR-->>UI: reporter instance
UI->>App: installResourcepack(file, progressReporter)
App->>PR: beginStage('install', 'Installing...')
par Download & Process
App->>PR: setProgress('download', 0.5)
PR->>UI: Update loading screen
App->>PR: setProgress('process', 0.75)
end
App->>PR: endStage('install')
App->>Backend: refresh assets
PR->>UI: setMessage('Ready!')
PR->>UI: end()
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Areas requiring extra attention:
Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (41)
📒 Files selected for processing (107)
⛔ Files not processed due to max files limit (36)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kennethkoontz
deleted the
ken-kra-800-fix-mouse-control-getting-stuck-in-iframe-during-runs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
UI/UX
Performance