dont forbid 1.21.8 but limit its usage in singleplayer

Author: zardoy

src/index.ts

@@ -101,6 +101,7 @@ import { getCurrentProxy, getCurrentUsername } from './react/ServersList'
 import { versionToNumber } from 'mc-assets/dist/utils'
 import { isPlayground } from './playgroundIntegration'
 import { appLoadBackend } from './appViewerLoad'
+import { FORBIDDEN_VERSION_THRESHOLD } from './supportedVersions.mjs'
 
 window.debug = debug
 window.beforeRenderFrame = []
@@ -399,11 +400,10 @@ export async function connect (connectOptions: ConnectOptions) {
     // Check for forbidden versions (>= 1.21.7) due to critical world display issues
     const checkForbiddenVersion = (version: string | undefined) => {
       if (!version) return
-      const FORBIDDEN_VERSION_THRESHOLD = '1.21.7'
       const versionNum = versionToNumber(version)
       const thresholdNum = versionToNumber(FORBIDDEN_VERSION_THRESHOLD)
       if (versionNum >= thresholdNum) {
-        throw new UserError(`Version ${version} is not supported due to critical world display issues. Please use version 1.21.6 or earlier.`)
+        throw new UserError(`Version ${version} is not supported due to critical world display issues. Please use version ${FORBIDDEN_VERSION_THRESHOLD} or earlier.`)
       }
     }
 

src/react/CreateWorldProvider.tsx

@@ -3,7 +3,7 @@ import path from 'path'
 import { hideCurrentModal, showModal } from '../globalState'
 import defaultLocalServerOptions from '../defaultLocalServerOptions'
 import { mkdirRecursive, uniqueFileNameFromWorldName } from '../browserfs'
-import supportedVersions from '../supportedVersions.mjs'
+import supportedVersions, { FORBIDDEN_VERSION_THRESHOLD_SINGLEPLAYER, versionToNumber } from '../supportedVersions.mjs'
 import { getServerPlugin } from '../clientMods'
 import CreateWorld, { WorldCustomize, creatingWorldState } from './CreateWorld'
 import { getWorldsPath } from './SingleplayerProvider'
@@ -13,7 +13,12 @@ export default () => {
   const activeCreate = useIsModalActive('create-world')
   const activeCustomize = useIsModalActive('customize-world')
   if (activeCreate) {
-    const versionsPerMinor = Object.fromEntries(supportedVersions.map(x => [x.split('.').slice(0, 2), x]))
+    const forbiddenThresholdNum = versionToNumber(FORBIDDEN_VERSION_THRESHOLD_SINGLEPLAYER)
+    const filteredVersions = supportedVersions.filter(x => {
+      const versionNum = versionToNumber(x)
+      return versionNum < forbiddenThresholdNum
+    })
+    const versionsPerMinor = Object.fromEntries(filteredVersions.map(x => [x.split('.').slice(0, 2), x]))
     const versions = Object.values(versionsPerMinor).map(x => {
       return {
         version: x,

src/supportedVersions.mjs

@@ -7,9 +7,9 @@ const versionsFromProtocol = Object.values(postNettyVersionsByProtocolVersion.pc
 
 export const notTestedVersions = '1.19.3 1.20 1.19.1 1.19 1.18.1 1.15.1 1.14.1'.split(' ')
 
-// Versions >= 1.21.7 are forbidden due to critical world display issues
-const FORBIDDEN_VERSION_THRESHOLD = '1.21.7'
-const versionToNumber = (ver) => {
+export const FORBIDDEN_VERSION_THRESHOLD = '1.21.1000'
+export const FORBIDDEN_VERSION_THRESHOLD_SINGLEPLAYER = '1.21.7'
+export const versionToNumber = (ver) => {
   const [x, y = '0', z = '0'] = ver.split('.')
   return +`${x.padStart(2, '0')}${y.padStart(2, '0')}${z.padStart(2, '0')}`
 }