fix retrocompatibility issues

Author: xaviergonz

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## 1.11.5
+
+- Fix: Some retrocompatibility issues with MobX 4/5.
+
 ## 1.11.4
 
 - Fix: redux devtools revert was not working correctly.

packages/lib/jest.config.ts

@@ -3,6 +3,7 @@ import { env } from "./env.js"
 import swcConfig from "./swc.config.js"
 
 const { mobxVersion, compiler } = env
+console.log(`Using mobxVersion=${mobxVersion}, compiler=${compiler}`)
 
 const tsconfigFiles = {
   6: compiler === "tsc" ? "tsconfig.json" : "tsconfig.experimental-decorators.json",

packages/lib/package.json

@@ -1,6 +1,6 @@
 {
   "name": "mobx-keystone",
-  "version": "1.11.4",
+  "version": "1.11.5",
   "description": "A MobX powered state management solution based on data trees with first class support for TypeScript, snapshots, patches and much more",
   "keywords": [
     "mobx",

packages/lib/src/wrappers/asMap.ts

@@ -1,15 +1,16 @@
 import {
   action,
   IMapWillChange,
-  intercept,
   IObjectDidChange,
   IObservableArray,
+  intercept,
   isObservableArray,
   isObservableObject,
-  observable,
   ObservableMap,
+  observable,
   observe,
   remove,
+  runInAction,
   transaction,
   untracked,
 } from "mobx"
@@ -143,8 +144,10 @@ const observableMapBackedByObservableArray = <T>(
       return observable.map(array)
     } else {
       const map = observable.map()
-      array.forEach(([k, v]) => {
-        map.set(k, v)
+      runInAction(() => {
+        array.forEach(([k, v]) => {
+          map.set(k, v)
+        })
       })
       return map
     }

packages/lib/src/wrappers/asSet.ts

@@ -1,12 +1,13 @@
 import {
   action,
-  intercept,
   IObservableArray,
   ISetWillChange,
+  intercept,
   isObservableArray,
-  observable,
   ObservableSet,
+  observable,
   observe,
+  runInAction,
   transaction,
   untracked,
 } from "mobx"
@@ -28,8 +29,10 @@ const observableSetBackedByObservableArray = <T>(
         return observable.set(array)
       } else {
         const set = observable.set()
-        array.forEach((item) => {
-          set.add(item)
+        runInAction(() => {
+          array.forEach((item) => {
+            set.add(item)
+          })
         })
         return set
       }

turbo.json

@@ -32,7 +32,7 @@
     "mobx-keystone#test": {
       "dependsOn": [],
       "outputs": [],
-      "env": ["COMPILER", "MOBX-VERSION"]
+      "env": ["COMPILER", "MOBX_VERSION"]
     },
     "mobx-keystone-yjs#test": {
       "dependsOn": ["mobx-keystone#build"],
@@ -41,7 +41,7 @@
     "mobx-keystone#test:ci": {
       "dependsOn": [],
       "outputs": [],
-      "env": ["COMPILER", "MOBX-VERSION"]
+      "env": ["COMPILER", "MOBX_VERSION"]
     },
     "mobx-keystone-yjs#test:ci": {
       "dependsOn": ["mobx-keystone#build"],