Skip to content

feat: sort tags by alphabetical order (WPB-21606) #4549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ohassine wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

feat: sort tags by alphabetical order (WPB-21606) #4549

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a50ed1
feat: sort tags by alphabetical order
ohassine Jan 27, 2026
e090f98
feat: cleanup
ohassine Jan 27, 2026
fcfd36f
Merge branch 'develop' into sort-tags-by-alphabetical-order
ohassine Jan 28, 2026
a990717
Merge branch 'develop' into sort-tags-by-alphabetical-order
MohamadJaara Jan 29, 2026
a508dd6
chore: cleanup
ohassine Jan 29, 2026
18eff05
chore: consider lowercase
ohassine Jan 29, 2026
9faa595
Merge branch 'develop' into sort-tags-by-alphabetical-order
ohassine Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ures/cells/src/main/java/com/wire/android/feature/cells/ui/tags/AddRemoveTagsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class AddRemoveTagsViewModel @Inject constructor(
init {
viewModelScope.launch {
getAllTagsUseCase().onSuccess { tags ->
_state.update { it.copy(allTags = tags) }
_state.update { it.copy(allTags = tags.sortedBy { tag -> tag.lowercase() }) }
}
snapshotFlow { tagsTextState.text.toString() }
.debounce(TYPING_DEBOUNCE_TIME)
Expand Down Expand Up @@ -124,7 +124,7 @@ data class TagsViewState(
val tagsUpdated: Boolean = false,
val addedTags: Set<String> = emptySet(),
val suggestedTags: Set<String> = emptySet(),
val allTags: Set<String> = emptySet(),
val allTags: List<String> = emptyList(),
Copy link
Contributor

@sbakhtiarov sbakhtiarov Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to keep set here? All tag collections (added, suggested) are defined as Set, I think we should keep this for allTags as well.

Copy link
Member Author

@ohassine ohassine Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, a Set does not preserve the order of its elements

)

sealed interface AddRemoveTagsViewModelAction {
Expand Down