New feature implemented: Autoresponder in HTML

[rileonar]

Hello,
I've developed a small update to allow user to choose autoresponder mail format between text-only (current) and htm, using same tinymce editor already used in mail compose.
I think this feature could be useful to some people (I saw some threads talking about it, some suggestions but no complete solution).
The update add a new selector called "HTML into Settings->Account->Autoreply page:

When the HTML selector is enabled, into textarea containing body of autoresponder is shown the tinymce html editor (the same used in compose mail process), and once the "Save" button is pressed the html is written to .ispconfig.sieve with proper mime header to format in html the mail sent by autoresponder.
When the HTML selector is disabled, the behavior is the "old one": the content of text area is handled as text only and the mail is sent by autoresponder without any mime header.
The HTML selector state is saved into database (user's mail properties).

I alredy submitted changes to ISPConfig3 project (3.2.11 version) in order to implement this feature:

• /usr/local/ispconfig/server/plugins-available/maildeliver_plugin.inc.php
  

• /usr/local/ispconfig/interface/web/mailuser/templates/mail_user_autoresponder_edit.htm
  

• /usr/local/ispconfig/interface/web/mail/form/mail_user.tform.php
  

• /usr/local/ispconfig/server/conf/sieve_filter.master_save /usr/local/ispconfig/server/conf/sieve_filter.master
  

• database dbispconfig, table mail_user, add field autoresponder_html
  

Now the only remaining file to change to implement the feature is:

• /usr/share/roundcube/plugins/ispconfig3_autoreply/ispconfig3_autoreply.php
  

If the update will be accepted there will be no more need for me to re-apply it at every ispconfig3_roundcube version upgrade and in fresh installations of ISPConfig.
Could you please provide me directions to submit this update in order to include it into next versions of ispconfig3_roundcube?

Thank you
Riccardo

[Churro]

Hi Riccardo, sounds great! Could you plese just open a PR here for review?

[rileonar]

Hi,
sorry but I don't know what is "PR".
You could allow me to fork this project, then modify ispconfig3_autoreply.php then commit it and submit a merge request...
Or, pls direct me what is easier for your environment... I could just paste here the modified version of that file.
My github name is rileonar
Tks,
Riccardo

[Churro]

Yes, please submit a merge request (= pull request = PR) 👍

[rileonar]

Hi Churro, PR open... please let me know if there is some mistake (I'm a sysadmin, not a developer 😊 )

[Churro]

Thx, I'm going to review it throughout the next days.

[rileonar]

Hello,
do you have any news about this feature?
I'm asking it just because I'm not a developer, so I don't know what is the tipical path (progress timeline) about this kind of change: how and when it will made available in the downloadable code...
Thank you in advance for your answer.
Riccardo

[Churro]

Sorry, I haven't had time to take a closer look yet. I have it on my agenda.

[Churro]

Hi @rileonar,
I have now taken a look at the PR you made to ISPConfig, noticing then that it was reverted on Oct 21.

Generally, I'd welcome this to be part of the Roundcube plugin but it makes only sense if the ISPConfig part is also there. Please reach out when this is the case so that we can revisit this.

[rileonar]

Hi @Churro ,
my PR made to ISPConfig seems to be accepted:
autoresponder email in html format
It should be available with version ISPConfig version 3.2.12
In the meantime, if you could direct me how to implement a simple check into the ispconfig3_autoreply.php to ensure the running ISPConfig version is at least 3.2.12, I will be glad to add it to the file and to resubmit the PR.
Thank you.

[Churro]

The issue you have linked refers to MR #1812, which was then reverted, see MR #1816. The revert commit was also the most recent one in mail_user.tform.php and other files, so obviously the autoresponder html part in ISPConfig is currently missing.

[rileonar]

Hi @Churro,
you are right, I wasn't aware that my change was first time accepted then reverted "because there are too many things missing".
Now I've asked for those missing things in order to provide them.
In the meantime I'm going to add the check into the ispconfig3_autoreply.php to ensure the running ISPConfig version is 3.2.12 or above, hoping the ispconfig side of the code will be merged into develop branch.
I'm sorry for this situation.
Riccardo