Skip to content

[VAL-7.0] Fails to build tools spotted by circleCI #94

@Fantu

Description

@Fantu

Distribution

Debian 10

Architecture

amd64

Kernel version

Blksnap version

commit bfb6122

Bug description

Preparing latest PR circleCI test on my fork failed to build tools with:

cd /root/project/build/pkg/obj-x86_64-linux-gnu/tools/blksnap && /usr/bin/cmake -E cmake_link_script CMakeFiles/blksnap-tools.dir/link.txt --verbose=1
/usr/bin/c++  -g -O2 -fdebug-prefix-map=/root/project/build/pkg=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wdate-time -D_FORTIFY_SOURCE=2 -static-libstdc++ -static-libgcc -O2 -g -DNDEBUG  -Wl,-z,relro -Wl,-z,now CMakeFiles/blksnap-tools.dir/main.cpp.o  -o blksnap /usr/lib/x86_64-linux-gnu/libuuid.so ../../lib/blksnap/libblksnap.a /usr/lib/x86_64-linux-gnu/libboost_program_options.a 
make[3]: Leaving directory '/root/project/build/pkg/obj-x86_64-linux-gnu'
[ 95%] Built target test_boundary
/usr/bin/ld: CMakeFiles/blksnap-tools.dir/main.cpp.o: in function `boost::system::error_category::std_category::equivalent(std::error_code const&, int) const':
/usr/include/boost/system/error_code.hpp:733: undefined reference to `boost::system::generic_category()'
/usr/bin/ld: /usr/include/boost/system/error_code.hpp:736: undefined reference to `boost::system::generic_category()'
/usr/bin/ld: /usr/include/boost/system/error_code.hpp:748: undefined reference to `boost::system::generic_category()'
/usr/bin/ld: CMakeFiles/blksnap-tools.dir/main.cpp.o: in function `boost::system::error_category::std_category::equivalent(int, std::error_condition const&) const':
/usr/include/boost/system/error_code.hpp:703: undefined reference to `boost::system::generic_category()'
/usr/bin/ld: /usr/include/boost/system/error_code.hpp:706: undefined reference to `boost::system::generic_category()'
collect2: error: ld returned 1 exit status
make[3]: *** [tools/blksnap/CMakeFiles/blksnap-tools.dir/build.make:90: tools/blksnap/blksnap] Error 1

From a fast look seems missed "system" to CMakeLists.txt about Boost.
In tools/blksnap/main.cpp I spotted also #include <boost/filesystem.hpp> that seems strange as that filesystem component was removed from CMakeLists.txt
After will need to update also Debian deps adding libboost-system-dev, build didn't stopped before because libboost-system-dev was installed as one of libboost-filesystem-dev deps

Steps to reproduce

No response

Expected behavior

No response

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions