use hooks manager as a private field

Author: sanish-bruno

packages/bruno-js/src/bru.js

@@ -6,10 +6,10 @@ const { jar: createCookieJar } = require('@usebruno/requests').cookies;
 
 const variableNameRegex = /^[\w-.]*$/;
 
-// Private WeakMap to store HookManager instances - truly private, not accessible from outside
-const hookManagerStore = new WeakMap();
-
 class Bru {
+  // Private class field - truly private, not accessible from outside the class
+  #hookManager;
+
   constructor(envVariables, runtimeVariables, processEnvVars, collectionPath, collectionVariables, folderVariables, requestVariables, globalEnvironmentVariables, oauth2CredentialVariables, collectionName, promptVariables, hookManager) {
     this.envVariables = envVariables || {};
     this.runtimeVariables = runtimeVariables || {};
@@ -22,10 +22,8 @@ class Bru {
     this.oauth2CredentialVariables = oauth2CredentialVariables || {};
     this.collectionPath = collectionPath;
     this.collectionName = collectionName;
-    // Store HookManager in WeakMap - truly private, not accessible via instance properties
-    if (hookManager) {
-      hookManagerStore.set(this, hookManager);
-    }
+    // Store HookManager in private class field - truly private, not accessible from outside
+    this.#hookManager = hookManager || null;
     this._initializeHooksConvenienceMethods();
     this.sendRequest = sendRequest;
     this.cookies = {
@@ -291,11 +289,10 @@ class Bru {
   /**
    * Initialize hooks convenience methods if hookManager is available
    * This creates a namespaced hooks object with only the convenience methods
-   * The HookManager itself is kept private in a WeakMap - truly inaccessible from outside
+   * The HookManager itself is kept private using a private class field - truly inaccessible from outside
    */
   _initializeHooksConvenienceMethods() {
-    const hookManager = hookManagerStore.get(this);
-    if (!hookManager) {
+    if (!this.#hookManager) {
       // Create empty hooks object if no hookManager
       this.hooks = {
         runner: {},
@@ -306,38 +303,34 @@ class Bru {
 
     // Create namespaced hooks object with only convenience methods
     // Users cannot access the HookManager directly (no .on() or .call() methods)
-    // The HookManager is stored in a WeakMap and is truly private
+    // The HookManager is stored in a private class field and is truly private
     this.hooks = {
       runner: {
         onBeforeCollectionRun: (handler) => {
-          const hm = hookManagerStore.get(this);
-          if (!hm) {
+          if (!this.#hookManager) {
             throw new Error('HookManager is not available');
           }
-          return hm.on('runner:beforeCollectionRun', handler);
+          return this.#hookManager.on('runner:beforeCollectionRun', handler);
         },
         onAfterCollectionRun: (handler) => {
-          const hm = hookManagerStore.get(this);
-          if (!hm) {
+          if (!this.#hookManager) {
             throw new Error('HookManager is not available');
           }
-          return hm.on('runner:afterCollectionRun', handler);
+          return this.#hookManager.on('runner:afterCollectionRun', handler);
         }
       },
       http: {
         onBeforeRequest: (handler) => {
-          const hm = hookManagerStore.get(this);
-          if (!hm) {
+          if (!this.#hookManager) {
             throw new Error('HookManager is not available');
           }
-          return hm.on('http:beforeRequest', handler);
+          return this.#hookManager.on('http:beforeRequest', handler);
         },
         onAfterResponse: (handler) => {
-          const hm = hookManagerStore.get(this);
-          if (!hm) {
+          if (!this.#hookManager) {
             throw new Error('HookManager is not available');
           }
-          return hm.on('http:afterResponse', handler);
+          return this.#hookManager.on('http:afterResponse', handler);
         }
       }
     };

packages/bruno-tests/hooks-comprehensive-tests/hooks/beforeRequest/async-before-request.bru

@@ -11,7 +11,7 @@ get {
 }
 
 script:hooks {
-  bru.hooks.http.onBeforeRequest(async({ req }) => {
+  bru.hooks.http.onBeforeRequest(async ({ req }) => {
     console.log('[beforeRequest] Starting async hook...');
 
     // Test: Can use async/await