TS error when using QuickLRU from readme example

[maslowivan]

export const cacheable = new CacheableLookup({
  cache: new QuickLRU({ maxSize: 1000 }),
});

Type 'QuickLRU<string, EntryObject[] | Promise<EntryObject[] | undefined>>' is not assignable to type 'CacheInstance'.
  Types of property 'set' are incompatible.
    Type '(key: string, value: EntryObject[] | Promise<EntryObject[] | undefined>, options?: { maxAge?: number | undefined; } | undefined) => QuickLRU<string, EntryObject[] | Promise<...>>' is not assignable to type '(hostname: string, entries: EntryObject[], ttl: number) => TPromise<boolean | void | CacheInstance>'.
      Types of parameters 'options' and 'ttl' are incompatible.
        Type 'number' is not assignable to type '{ maxAge?: number | undefined; } | undefined'.ts(2322)

[renatomariscal]

What version of the libraries are you using? cacheable-lookup, quick-lru and typescript

[szmarczak]

Good catch!

cacheable-lookup/index.d.ts

Line 11 in 45b18da

set(hostname: string, entries: EntryObject[], ttl: number): TPromise<void | boolean | this>;

	set(hostname: string, entries: EntryObject[], ttl: number): TPromise<void | boolean | this>;
+	set(hostname: string, entries: EntryObject[]): TPromise<void | boolean | this>;

I think this should work. Not tested yet.

[viceice]

seeing same error:

[viceice]

ok downgrade to v5 of both fixed the issue and is compatible with got v11

[dontbesatisfied]

i'm using 7.0.0 but it now fixed and 5.0.4 does not work.

[iamchathu]

This issue still exists for 7.0.0 of both packages

[Stono]

Yeah just to confirm; i'm using the latest version of cacheable-lookup (7.0.0 - although is the same with 6x) and I get type errors against both v6 and v7 of quick-lru.

So it seems to be that quick-lru is only compatible with cacheable-lookup if you're on v5 (current v7)

quick-lru's type for set:

set(key: KeyType, value: ValueType, options?: {maxAge?: number}): this;

cacheable-lookup's type for set:

set(hostname: string, entries: EntryObject[], ttl: number): TPromise<void | boolean | this>;

As you can see, quick-lru looks to be expecting an object with maxAge rather than what cacheable-lookup is doing which is passing an int

[iamchathu]

Is there any update on fixing this issue?