fix: null pointer exception error fields [IDE-1581] (#745)

* fix: use correct error fields in tree node text methods

Fix NullPointerException issues in getNewIacTreeNodeText and getNewOssTreeNodeText:
- In getNewIacTreeNodeText: use currentIacError instead of currentSnykCodeError when currentIacError is not null
- In getNewOssTreeNodeText: use currentOssError instead of currentSnykCodeError when realError is true

Both methods were accessing the wrong error field, which could be null and cause NullPointerExceptions.

* fix: improve error handling consistency in tree node text

- Fixed OSS to check errors before scanning status (matching IAC and Code Security)
- Fixed IAC to filter errors when no supported files found (matching OSS behavior)
- Updated CHANGELOG with 2.18.1 fixes

Author: acke

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Snyk Security Changelog
 
+## [2.18.1]
+### Fixed
+- Fixed Agent Fix not applying edits for file paths containing spaces or special characters by properly handling URL-encoded URIs in workspace edit operations
+- Fixed inconsistent error handling in tree node text: OSS now checks for errors before scanning status (matching IAC and Code Security behavior)
+- Fixed IAC error display to filter out errors when no supported files are found, matching OSS behavior
 ## [2.18.0]
 ### Changed
 - Added organization configuration at project level

src/main/kotlin/io/snyk/plugin/ui/toolwindow/SnykToolWindowPanel.kt

@@ -510,17 +510,19 @@ class SnykToolWindowPanel(
     ) {
         val settings = pluginSettings()
 
-        val realError =
+        val realOssError =
             getSnykCachedResults(project)?.currentOssError != null && ossResultsCount != NODE_NOT_SUPPORTED_STATE
+        val realIacError =
+            getSnykCachedResults(project)?.currentIacError != null && iacResultsCount != NODE_NOT_SUPPORTED_STATE
 
-        val newOssTreeNodeText = getNewOssTreeNodeText(settings, realError, ossResultsCount, addHMLPostfix)
+        val newOssTreeNodeText = getNewOssTreeNodeText(settings, realOssError, ossResultsCount, addHMLPostfix)
         newOssTreeNodeText?.let { rootOssTreeNode.userObject = it }
 
         val newSecurityIssuesNodeText =
             getNewSecurityIssuesNodeText(settings, securityIssuesCount, addHMLPostfix)
         newSecurityIssuesNodeText?.let { rootSecurityIssuesTreeNode.userObject = it }
 
-        val newIacTreeNodeText = getNewIacTreeNodeText(settings, iacResultsCount, addHMLPostfix)
+        val newIacTreeNodeText = getNewIacTreeNodeText(settings, realIacError, iacResultsCount, addHMLPostfix)
         newIacTreeNodeText?.let { rootIacIssuesTreeNode.userObject = it }
 
         val newRootTreeNodeText = getNewRootTreeNodeText()
@@ -538,11 +540,12 @@ class SnykToolWindowPanel(
 
     private fun getNewIacTreeNodeText(
         settings: SnykApplicationSettingsStateService,
+        realError: Boolean,
         iacResultsCount: Int?,
         addHMLPostfix: String
     ) = when {
-        getSnykCachedResults(project)?.currentIacError != null -> {
-            val errorSuffix = getSnykCachedResults(project)!!.currentSnykCodeError!!.treeNodeSuffix
+        realError -> {
+            val errorSuffix = getSnykCachedResults(project)!!.currentIacError!!.treeNodeSuffix
             "$IAC_ROOT_TEXT $errorSuffix"
         }
         isIacRunning(project) && settings.iacScanEnabled -> "$IAC_ROOT_TEXT (scanning...)"
@@ -589,11 +592,11 @@ class SnykToolWindowPanel(
         ossResultsCount: Int?,
         addHMLPostfix: String
     ) = when {
-        isOssRunning(project) && settings.ossScanEnable -> "$OSS_ROOT_TEXT (scanning...)"
         realError -> {
-            val errorSuffix = getSnykCachedResults(project)!!.currentSnykCodeError!!.treeNodeSuffix
+            val errorSuffix = getSnykCachedResults(project)!!.currentOssError!!.treeNodeSuffix
             "$OSS_ROOT_TEXT $errorSuffix"
         }
+        isOssRunning(project) && settings.ossScanEnable -> "$OSS_ROOT_TEXT (scanning...)"
 
         else ->
             ossResultsCount?.let { count ->