React 18 Upgrade #1128
joelhooks
started this conversation in
Ideas & Research
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Keeping a thread of issues with the React 18 upgrade path
They have a great codemod for a lot of the more tedious aspects. The biggest one that affects us is that the
childrenprop is no longer implicit with types:https://github.com/eps1lon/types-react-codemod
npx types-react-codemod preset-18 ./srcWas able to run this without issue.
Had to update several libraries and it generally seems like upstream updates will be required. For us that includes the
@skillrecordings/playerpackage. Haven't explored if that functions as expected if we set React as a peer dependency upstream.I was able to get most home, search, and courses displaying after updating
react-use,@xstate/react, and@tanem/react-nprogressThe
browsemenu in the page nave wouldn't function though so I suspect that is an issueBeta Was this translation helpful? Give feedback.
All reactions