feat: implement async support for SQLJoinQueryEnginefeat: implement async support for SQLJoinQueryEnginefeat: implement async support for SQLJoinQueryEnginePatch 2 #20342
+172
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for SQLJoinQueryEngine Implemented _aquery and _aquery_sql_other in SQLJoinQueryEngine to support asynchronous execution, filling a previous TODO.
…r async SQLJoinQueryEngine
dosubot
bot
added
the
size:L
emorilebo
changed the title
emorilebo
changed the title
llama-index-core/llama_index/core/query_engine/sql_join_query_engine.py
Outdated
Show resolved
Hide resolved
revert unrelated formatting change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented asynchronous support (
_aquery) for theSQLJoinQueryEngineto address the existing TODO.The implementation now correctly awaits the selector, SQL query engine, and LLM prediction, preventing blocking calls during async execution.
Added unit tests in
tests/query_engine/test_sql_join_query_engine.pyverifying both synchronous and asynchronous behavior usingAsyncMock.