fix: pass timeout parameters to transport clients in BasicMCPClient #20340
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes run-llama#20272 The user-specified timeout parameter was not being passed to the underlying transport clients (sse_client and streamablehttp_client), causing them to use their default timeouts instead. Changes: - Add sse_read_timeout parameter to BasicMCPClient.__init__() and with_oauth() - Pass timeout and sse_read_timeout to sse_client() in _run_session() - Pass timeout and sse_read_timeout to streamablehttp_client() in _run_session() - Update docstrings to document the new parameter
dosubot
bot
added
the
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20272
The user-specified
timeoutparameter was not being propagated to the underlying transport clients (sse_clientandstreamablehttp_client), causing them to use their default timeouts (5s and 30s respectively) instead of the user's configured value.Changes
sse_read_timeoutparameter toBasicMCPClient.__init__()andwith_oauth()with a default of 300 seconds (5 minutes)timeoutandsse_read_timeouttosse_client()in_run_session()timeoutandsse_read_timeouttostreamablehttp_client()in_run_session()Testing
Tested manually by:
timeout=60- successfully completesstreamablehttp_client