Apply attrs' converter to default before omit_if_default check #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @Tinche! I've added a test to fix coverage, but don't really know what are the next steps to get this merged, can I get a review from you? |
Member
|
Yep, I've been busy but this is on my mind to review soon! |
Tinche
requested changes
Nov 11, 2025
Member
Tinche
left a comment
Tinche
left a comment
There was a problem hiding this comment.
Also, we need some docs: please add a versionchanged line to the function docstring (you can use NEXT as the version), and a changelog entry.
Tinche
requested changes
Nov 25, 2025
Member
Tinche
left a comment
Tinche
left a comment
There was a problem hiding this comment.
Left a comment, but LGTM. I'll be back in a few days to take a closer look.
Member
|
Great job, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.