Fix broken tests

[bit-pirate]

Running tests shows a couple of failing ones:

Running tests...
Test project /opt/rocon_workspace/build
      Start  1: _ctest_capabilities_nosetests_test
 1/41 Test  #1: _ctest_capabilities_nosetests_test ..................................................................***Failed    0.74 sec
      Start  2: _ctest_capabilities_rostest_test_rostest_test_client_test_client_module.test
 2/41 Test  #2: _ctest_capabilities_rostest_test_rostest_test_client_test_client_module.test ........................***Failed    2.05 sec
      Start  3: _ctest_capabilities_rostest_test_rostest_test_launch_manager_test_launch_manager.test
 3/41 Test  #3: _ctest_capabilities_rostest_test_rostest_test_launch_manager_test_launch_manager.test ...............***Failed    1.38 sec
      Start  4: _ctest_capabilities_rostest_test_rostest_test_server_test_client.test
 4/41 Test  #4: _ctest_capabilities_rostest_test_rostest_test_server_test_client.test ...............................***Failed    1.60 sec
      Start  5: _ctest_capabilities_rostest_test_rostest_test_server_test_default_provider.test
 5/41 Test  #5: _ctest_capabilities_rostest_test_rostest_test_server_test_default_provider.test .....................***Failed    1.65 sec
      Start  6: _ctest_capabilities_rostest_test_rostest_test_server_test_dependent_capabilities.test
 6/41 Test  #6: _ctest_capabilities_rostest_test_rostest_test_server_test_dependent_capabilities.test ...............***Failed    1.75 sec
      Start  7: _ctest_capabilities_rostest_test_rostest_test_server_test_invalid_specs.test
 7/41 Test  #7: _ctest_capabilities_rostest_test_rostest_test_server_test_invalid_specs.test ........................***Failed    1.58 sec
      Start  8: _ctest_capabilities_rostest_test_rostest_test_server_test_package_white_black_lists.test
 8/41 Test  #8: _ctest_capabilities_rostest_test_rostest_test_server_test_package_white_black_lists.test ............***Failed    1.65 sec
      Start  9: _ctest_capabilities_rostest_test_rostest_test_server_test_remapping.test
 9/41 Test  #9: _ctest_capabilities_rostest_test_rostest_test_server_test_remapping.test ............................***Failed    1.59 sec
      Start 10: _ctest_capabilities_rostest_test_rostest_test_server_test_ros_services.test
10/41 Test #10: _ctest_capabilities_rostest_test_rostest_test_server_test_ros_services.test .........................***Failed    1.65 sec
      Start 11: _ctest_capabilities_rostest_test_rostest_test_server_test_white_black_lists.test
11/41 Test #11: _ctest_capabilities_rostest_test_rostest_test_server_test_white_black_lists.test ....................***Failed    1.65 sec
      Start 12: _ctest_capabilities_rostest_test_rostest_test_service_discovery_test_spec_index_from_service.test
12/41 Test #12: _ctest_capabilities_rostest_test_rostest_test_service_discovery_test_spec_index_from_service.test ...***Failed    2.12 sec

Am I doing sth wrong?

[wjwwood]

How did you run the tests?

[wjwwood]

The CI is passing and reporting 100% coverage, so there are no broken tests as far as I know.

[wjwwood]

After looking around, I think you might be talking about the devel job on the build farm?

I added this commit to try and fix that (pep8, coverage, and mock were not installed): b76c483

I also had to add a rule for python-pep8: ros/rosdistro#3947

[wjwwood]

Ok, in 551e274 I fixed it such that it doesn't depend on the coverage script being in the PATH, because it is called python-coverage on Ubuntu...

That should clear up the failures on the farm.

[bit-pirate]

Sorry for the late reply. All capabilities tests are no passing on my machine. I believe this was mostly due to the missing mock and pep8 dependencies.

However, I still get notifications about test failures on the buildfarm: http://jenkins.ros.org/job/devel-hydro-capabilities/ Is this just the source build triggered by new commits in a repo? The deb build seem to be all fine.

Also I don't know, why I'm actually getting those notifications.

[wjwwood]

I think you are getting the notifications because you contributed to the repository since the last release? I'm not 100% sure on that one.

Yeah you have to have mock and pep8 and coverage installed and from debs the executable for coverage is called python-coverage instead of just coverage so it worked on my machine and on travis (because it uses pip), but not on Linux with coverage installed from apt-get. I have fixed those issues though.

The only outstanding issue that I know of (for the devel jobs) is that the pep8 module getting installed seems to have a different API... Very frustrating. I'll try to clean it up soon. Honestly I would just turn off the jenkins.ros.org devel job, since we have travis-ci, but that currently isn't supported. There just aren't enough hours in the day.

[bit-pirate]

There just aren't enough hours in the day.

Dito.

Then I'll leave this issue open until Jenkins is happy. Feel free to close it at your convenience.