AssertJ: Refactor `assertThat(list.size())isEqualsTo()` -> `hasSize()` with `as(String message)`

[kthoms]

What problem are you trying to solve?

Resolve Sonar issues of type "Chained AssertJ assertions should be simplified to the corresponding dedicated assertion java:S5838"

What precondition(s) should be checked before applying this recipe?

AssertJ must be present

Describe the situation before applying the recipe

class A {
    void foo(List bar) {
        assertThat(bar.size()).isEqualTo(5);
    }
    void foo2(List bar) {
        assertThat(bar.size()).isEqualTo(0);
    }
}

Describe the situation after applying the recipe

class A {
    void foo(List bar) {
        assertThat(bar).hasSize(5);
    }
    void foo2(List bar) {
        assertThat(bar).isEmpty();
    }
}

Have you considered any alternatives or workarounds?

IntelliJ IDEA is able to refactor these occurrences.

Any additional context

Are you interested in contributing this recipe to OpenRewrite?

Not ATM.

[timtebeek]

• Proposed in Add AssertJIterableRules.AssertThatCollectionHasSize PicnicSupermarket/error-prone-support#1872

[timtebeek]

Turns out it's the as intermediate that's causing the methods not to match here. We'd need to revise how we implement those methods for this to be supported as well, as it looks like it's not an easy addition to Picnic's EPS. 🤔