Control Flow Visualization generated as comment as opposed to new stand alone file

[Jothianand]

Dot file is not generated while running the Control Flow Visualization recipe.

After running the recipe, it is adding the diagraph notations to the class but the dot file is not generated.

Have tried with both includeDotfile as true & false, but not generating the file. When includeDotfile is true, its adding diagraph notions and when false, it is not added.

Do we need to use a separate recipe to generate the dot file from the notations added by the recipe ?

---
type: specs.openrewrite.org/v1beta/recipe
name: com.yourorg.ControlFlowVisualizationExample
displayName: Control Flow Visualization example
recipeList:
  - org.openrewrite.analysis.controlflow.ControlFlowVisualization:
      includeDotfile: true

[timtebeek]

It indeed looks like the recipe produces the dot notation as a comment in the code, as opposed to in a separate file, as seen here:

rewrite-analysis/src/main/java/org/openrewrite/analysis/controlflow/ControlFlowVisualizationVisitor.java

Lines 82 to 90 in 9ced24c

	if (dotFileGenerator != null) {
	String graphName = methodDeclaration != null ? methodDeclaration.getSimpleName() : b.isStatic() ? "static block" : "init block";
	String dotFile = dotFileGenerator.visualizeAsDotfile(graphName, darkMode, controlFlow);
	if (isMethodDeclaration) {
	getCursor().dropParentUntil(J.MethodDeclaration.class::isInstance).putMessage(CONTROL_FLOW_SUMMARY_CURSOR_MESSAGE, dotFile);
	} else {
	J.Block b2 = SearchResult.found(b, searchResultText);
	return SearchResult.mergingFound(b2, dotFile);
	}

We could restructure the recipe to be a Scanning recipe that creates a new file instead of a comment, if you feel that improves the experience. I'd welcome a PR that explores that solution to this issue.

[Jothianand]

Thanks @timtebeek for the response.

I feel that the recipe should generate the dot file so that developers can visualise their code flow.