Stabilize part of SDK spec for synchronous instrument Enabled #4787
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes the specification language around eventual visibility of configuration changes for the Enabled method across all OpenTelemetry signals (traces, metrics, and logs). The changes ensure consistent wording and placement of visibility guarantees while clarifying that metrics specifications apply specifically to synchronous instruments.
- Generalized the visibility statement from referencing specific parameters to "any of these parameters"
- Added clarification that metrics
EnabledSDK specification applies to synchronous instruments - Moved and consolidated visibility guarantees to eliminate duplication
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| specification/trace/sdk.md | De-indented visibility statement in TracerConfig to apply to all parameters at section level |
| specification/metrics/sdk.md | Added visibility statement to MeterConfig, clarified synchronous instrument scope, added inline status annotation to first condition, and removed duplicate visibility text |
| CHANGELOG.md | Added changelog entry documenting the stabilization of part of the Enabled SDK for synchronous instruments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Is this something we should wait to include in the January's release? |
I think this one should be high confidence and low risk, I suggest that we merge. |
5 participants
Per #4746 (review)
Side note. I also made sure that this wording used for all signals (and in the same place)
so that the spec is similar for all signals