Skip to content

Commit 4ccd758

Browse files
0xshubhsadiati98
andauthored
docs: Add information about PR with unassigned issue to the contributing guidelines (#252)
* Feature: Added information about PR with unassigned issue to the contributing guidelines #251 * Feature: Added information about PR with unassigned issue to the contributing guidelines #251 * fixes : removed horizontal lines and also the underscore(italics) * changes in package.json / docs/contributing/introduction-to-contributing.md * fix: add break line --------- Co-authored-by: Ayu Adiati <[email protected]>
1 parent 83e4fbc commit 4ccd758

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

docs/contributing/introduction-to-contributing.md

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,11 @@ After running this command, you can push your changes to the remote repo.
5151
See [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) for more examples.
5252

5353
## Pull Requests (PR)
54+
---
55+
56+
We actively welcome your pull requests. However, you must ensure that **you are assigned** to an existing issue before working on changes, and you need to **link your work to the issue** in your PR form.
5457

55-
**_We actively welcome your pull requests. However, you must link your work to an existing issue._**
58+
---
5659

5760
1. Fork the repo and create your branch from the default branch.
5861
2. Name your branch to something descriptive of your work, i.e., `add-navbar` or `fix/broken-links`.
@@ -66,9 +69,14 @@ See [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) for m
6669

6770
- The title must begin with "feat:", "fix:", or anything related to your changes. <br /> **Tips**: You can follow your chosen option when [committing](#commits) your changes.
6871

69-
- Unsolicited code is welcomed, but an issue is required to announce your intentions. <br /> **_PRs without a linked issue will be marked invalid and closed_**.
70-
71-
> [!IMPORTANT]
72+
- Unsolicited code is welcomed, but an issue is required to announce your intentions.
73+
74+
⚠️ **PRs will be marked as invalid and may be closed if:**
75+
76+
- the issue is not assigned to the contributor who opened the PR
77+
- no issue is linked to the PR
78+
79+
> **IMPORTANT:** <br />
7280
> Please do not DM Maintainers or contact them outside of GitHub if you want a PR Review. If you haven't received a review within a week, please tag them in the PR comments to ask for an estimated time of review.
7381
7482
> _**Note for maintainers**: All PRs need a label to assist automation. See [this guide](./triage-guide.md#adding-issue-and-pr-labels) to determine which labels to use._

0 commit comments

Comments
 (0)