Skip to content

Respect push.default=current configuration in push command #281486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bstaeheli wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Respect push.default=current configuration in push command #281486

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1ada01
Respect push.default=current configuration in push command
SwissSalaryBoris Dec 5, 2025
fdc7208
Merge branch 'main' into feature/respect-push-default-current
bstaeheli Dec 5, 2025
1dcc949
Update extensions/git/src/repository.ts
bstaeheli Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion extensions/git/src/repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2078,7 +2078,14 @@ export class Repository implements Disposable {

if (head && head.name && head.upstream) {
remote = head.upstream.remote;
branch = `${head.name}:${head.upstream.name}`;

// Respect push.default=current configuration
const pushDefault = await this.repository.config('get', '', 'push.default');
if (pushDefault === 'current') {
branch = head.name;
} else {
branch = `${head.name}:${head.upstream.name}`;
}
Comment on lines 2082 to 2088
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new push.default=current configuration handling lacks test coverage. Consider adding tests to verify:

  1. Push behavior when push.default=current is set (should use head.name as branch)
  2. Push behavior when push.default is unset or set to other values (should use head.name:head.upstream.name)
  3. Push behavior when config read fails (returns empty string)

Copilot uses AI. Check for mistakes.
}

await this.run(Operation.Push, () => this._push(remote, branch, undefined, undefined, forcePushMode));
Expand Down