Add activity bar hover foreground and background color definitions #279525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes microsoft#210694 Added 4 new theme color definitions for activity bar hover states: - activityBar.hoverForeground - activityBar.hoverBackground - activityBarTop.hoverForeground - activityBarTop.hoverBackground These allow users to customize the foreground and background colors when hovering over activity bar items in both side and top/bottom positions.
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210694
Summary
Added 4 new theme color definitions for activity bar hover states:
activityBar.hoverForeground- Foreground color when hovering over activity bar itemsactivityBar.hoverBackground- Background color when hovering over activity bar itemsactivityBarTop.hoverForeground- Foreground color when hovering (top/bottom position)activityBarTop.hoverBackground- Background color when hovering (top/bottom position)Description
These new color tokens allow users to customize the foreground and background colors when hovering over activity bar items, in both the side position and top/bottom positions.
The implementation follows the existing pattern used for other activity bar colors and tab hover colors in the codebase.
Testing
nulldefault values (consistent with other hover colors)settings.jsonunderworkbench.colorCustomizations