Add support for AN NIC without a linked synthetic device #4074

adityagesh · 2025-10-27T07:12:40Z

No description provided.

adityagesh · 2025-10-27T07:15:41Z

lisa/nic.py

+            # Try to find the PCI slot for this NIC by checking its device path
+            result = self._node.execute(
+                f"readlink -f /sys/class/net/{nic_name}/device",
+                shell=True,
+            )
+            if result.exit_code == 0 and result.stdout.strip():
+                # Extract PCI slot from device path
+                # Path format: /sys/devices/.../XXXX:XX:XX.X/net/nicname
+                match = self.__pci_slot_pattern.search(result.stdout)
+                if match:
+                    pci_slot = match.group(1)
+                    # Get the module name for this PCI device
+                    try:
+                        module_name = lspci.get_used_module(pci_slot)
+                        if module_name:
+                            nic.pci_slot = pci_slot
+                            # For standalone PCI NICs, set module_name directly
+                            # (no lower_module_name since there's no lower device)
+                            nic.module_name = module_name
+                            self._node.log.debug(
+                                f"Associated unpaired NIC {nic_name} "
+                                f"with PCI slot {pci_slot} (module: {module_name})"
+                            )
+                        else:
+                            self._node.log.debug(


I am not sure if this is the right place for this code.
If it is the right place, is it sufficient to just move the below code to a tool?

result = self._node.execute( f"readlink -f /sys/class/net/{nic_name}/device", shell=True, ) # Path format: /sys/devices/.../XXXX:XX:XX.X/net/nicname match = self.__pci_slot_pattern.search(result.stdout) if match: pci_slot = match.group(1)

yes, use tool is always better.

Handle enable/disable test cases Handle PCI NIC count

Copilot · 2025-11-28T04:04:13Z

@adityagesh I've opened a new pull request, #4138, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

This pull request adds comprehensive support for Accelerated Networking (AN) NICs that operate as standalone PCI devices without synthetic NIC pairing. This architectural enhancement enables LISA to handle three distinct NIC configurations: synthetic-only NICs, traditional paired NICs (synthetic+VF), and the newly supported PCI-only NICs.

Key changes:

Introduces a Readlink tool to replace direct readlink command execution, providing proper error handling and abstraction
Refactors NIC detection logic to discover and handle standalone PCI NICs through device path analysis
Updates network test suites to skip synthetic-specific tests when running on PCI-only NIC configurations

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
lisa/tools/readlink.py	New tool for reading symbolic links with proper error handling and two methods: get_target() and get_canonical_path()
lisa/tools/lspci.py	Adds get_pci_slot_from_device_path() method to extract PCI slot information from sysfs device paths
lisa/tools/init.py	Exports new Readlink tool
lisa/nic.py	Core refactoring: adds is_pci_only_nic property, renames get_lower_nics() to get_pci_nics(), adds get_synthetic_devices(), implements _discover_standalone_pci_nics() for PCI-only NIC detection
lisa/microsoft/testsuites/network/synthetic.py	Adds synthetic NIC availability checks to skip tests on PCI-only configurations
lisa/microsoft/testsuites/network/stress.py	Adds skip conditions for synthetic and SRIOV disable/enable tests on PCI-only NICs
lisa/microsoft/testsuites/network/sriov.py	Adds skip conditions for SRIOV disable/enable tests on PCI-only NICs
lisa/microsoft/testsuites/network/networksettings.py	Adds synthetic NIC checks and updates to use is_pci_module_enabled and pci_device_name properties
lisa/microsoft/testsuites/network/common.py	Updates NIC selection logic to use is_pci_module_enabled instead of checking nic.lower
lisa/microsoft/testsuites/xdp/common.py	Replaces nic.lower with nic.pci_device_name for proper PCI device name retrieval
lisa/microsoft/testsuites/power/common.py	Updates calls from get_lower_nics() to get_pci_nics()
lisa/microsoft/testsuites/performance/common.py	Updates calls from get_lower_nics() to get_pci_nics()
lisa/microsoft/testsuites/core/provisioning.py	Updates calls from get_lower_nics() to get_pci_nics() and fixes string formatting
lisa/microsoft/testsuites/xfstests/xfstesting.py	Reorganizes imports to follow PEP 8 (stdlib/third-party before local imports)
lisa/microsoft/testsuites/ltp/ltpsuite.py	Reorganizes imports to follow PEP 8
lisa/microsoft/testsuites/kselftest/kselftest-suite.py	Reorganizes imports to follow PEP 8

Copilot · 2025-11-28T04:09:56Z

lisa/nic.py

+        for nic in self.nics.values():
+            if nic.is_pci_only_nic:
+                pci_nics.append(nic.name)
+            else:


The method appends nic.lower for all non-PCI-only NICs, including synthetic NICs that have no lower device. This results in empty strings being added to the list. The logic should only append when there's an actual PCI device. Consider: if nic.is_pci_only_nic: pci_nics.append(nic.name) followed by elif nic.lower: pci_nics.append(nic.lower) to avoid adding empty strings for synthetic NICs without PCI devices.

Suggested change

else:

elif nic.lower:

Copilot · 2025-11-28T04:09:56Z

lisa/nic.py

+                f"Nic set was {self.nics.keys()} and only found info for "
+                f"{found_nics}"


[nitpick] The string split across lines breaks PEP 8 convention unnecessarily. The original single-line f-string was under the typical 88-100 character limit for modern Python style. Consider reverting to a single line for better readability.

lisa/microsoft/testsuites/core/provisioning.py

Copilot · 2025-11-28T04:09:57Z

lisa/tools/readlink.py

+            canonicalize=True,
+            sudo=sudo,
+            no_error_log=no_error_log,
+        )


The new Readlink tool lacks test coverage. Consider adding unit tests to verify the tool's behavior for valid symbolic links, broken links, and the no_error_log parameter functionality, especially since this tool is now used in critical NIC discovery paths.

Copilot · 2025-11-28T04:09:57Z

lisa/nic.py

    def is_mana_driver_enabled(self) -> bool:
        return self._node.tools[KernelConfig].is_enabled("CONFIG_MICROSOFT_MANA")

+    def _discover_standalone_pci_nics(self, lspci: Lspci) -> None:


The new _discover_standalone_pci_nics method, which is central to the PR's functionality, lacks integration test coverage. Consider adding tests that verify standalone PCI NIC discovery works correctly for PCI-only NIC configurations.

adityagesh commented Oct 27, 2025

View reviewed changes

adityagesh force-pushed the net_test_en_new branch from 32b76f6 to c3414f5 Compare November 27, 2025 03:56

adityagesh and others added 4 commits November 28, 2025 04:00

NIC: Associate PCI with MANA interface

02bc46e

Network test cases enhancements

ace9d79

Handle enable/disable test cases Handle PCI NIC count

Add ReadLink Tool

01926a2

Use ReadLink in NIC.py

68b9623

adityagesh force-pushed the net_test_en_new branch from c3414f5 to daf2203 Compare November 28, 2025 04:01

adityagesh marked this pull request as ready for review November 28, 2025 04:03

adityagesh requested a review from LiliDeng as a code owner November 28, 2025 04:03

Copilot AI mentioned this pull request Nov 28, 2025

[WIP] Add support for AN NIC without a linked synthetic device #4138

Closed

adityagesh force-pushed the net_test_en_new branch from daf2203 to fd5635a Compare November 28, 2025 04:06

adityagesh requested a review from Copilot November 28, 2025 04:06

Copilot started reviewing on behalf of adityagesh November 28, 2025 04:06 View session

Copilot finished reviewing on behalf of adityagesh November 28, 2025 04:09

Copilot AI reviewed Nov 28, 2025

View reviewed changes

Fix mypy and flake errors

e24ed5f

adityagesh force-pushed the net_test_en_new branch from fd5635a to e24ed5f Compare November 28, 2025 04:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for AN NIC without a linked synthetic device #4074

Add support for AN NIC without a linked synthetic device #4074

Uh oh!

adityagesh commented Oct 27, 2025

Uh oh!

adityagesh Oct 27, 2025 •

edited

Loading

Uh oh!

squirrelsc Oct 27, 2025

Uh oh!

Copilot AI commented Nov 28, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Copilot AI Nov 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		f"Nic set was {self.nics.keys()} and only found info for "
		f"{found_nics}"

Add support for AN NIC without a linked synthetic device #4074

Are you sure you want to change the base?

Add support for AN NIC without a linked synthetic device #4074

Uh oh!

Conversation

adityagesh commented Oct 27, 2025

Uh oh!

adityagesh Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

squirrelsc Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

adityagesh Oct 27, 2025 •

edited

Loading